Draft for OWA_v5.1.14 release #371
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates from v5.1.13 11/27/17 to v5.1.13 5/10/18
Updates compiler and linker settings to match results generated with VS2017_DLL project file distributed with swmm release
Reconciles differences
Moves def file to bindings folder Adds build option for def file
Changes default abs tol from 0.0 to 1.E0-6
Release 5.1.14
Merging develop <-- master
toolkit pollutant setter and getter fixes
1. Fixed spacing for swmm_getNodePollut. 2. Added *length parameter to the SM_NODECIN and SM_NODEREACTORC cases in getNodePollut. 3. Added case for SM_LINKREACTORC in swmm_getLinkPollut.
Have not run tests yet but committing to save changes.
1. Added a check to confirm length is getting pulled/set correctly. 2. Added a test for link reactorQual.
1. Wrote setNodePollut like setLinkPollut in toolkit.c and toolkit.h. Before it did not take the SM_NodePollut type so I added it. 2. Modified the tests in test_pollut.cpp to include this new parameter. Passed the tests.
Moved length statement out of switch case for both node and link getters to make the code more concise.
- link libraries statically using BUILD_SHARED_LIBS=OFF
Checked object index but incorrectly called Nobjects[NODE] instead of Nobjects[LINK]
1. Fixed spacing for swmm_getNodePollut. 2. Added *length parameter to the SM_NODECIN and SM_NODEREACTORC cases in getNodePollut. 3. Added case for SM_LINKREACTORC in swmm_getLinkPollut.
Have not run tests yet but committing to save changes.
1. Added a check to confirm length is getting pulled/set correctly. 2. Added a test for link reactorQual.
1. Wrote setNodePollut like setLinkPollut in toolkit.c and toolkit.h. Before it did not take the SM_NodePollut type so I added it. 2. Modified the tests in test_pollut.cpp to include this new parameter. Passed the tests.
Moved length statement out of switch case for both node and link getters to make the code more concise.
Checked object index but incorrectly called Nobjects[NODE] instead of Nobjects[LINK]
Updates for pollutant getter functionalities for links/nodes and relevant tests.
|
Closing this PR. Was supposed to be release_version to master, not develop to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for us to review the changes and additions since the previous release and prep the code for release.