Update GitHub actions runners #369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- link libraries statically using BUILD_SHARED_LIBS=OFF
|
@abhiramm7 and @michaeltryby, With the updates to ci-tools and swmm-nrtestsuite, the new action runners are passing tests. I think this PR should be ready to merge with your approvals. |
abhiramm7
requested changes
Apr 13, 2022
abhiramm7
approved these changes
Apr 13, 2022
|
Thanks @karosc this is perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates build-test.yml windows to VS 2022 and Ubuntu to 20.04
To solve issues shown in #340, CMakeLists.txt were edited to support cmake option BUILD_SHARED_LIBS. Coupled with changes to the ci-tools repo, this PR will allow developers to optionally use static linking with SWMM libraries.
This update is prompted by discussions in #368