Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub actions runners #369

Merged
merged 4 commits into from
Apr 13, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions .github/workflows/build-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [windows-2016, ubuntu-16.04, macos-10.15]
os: [windows-2022, ubuntu-20.04, macos-10.15]
requirements: [requirements-swmm.txt]
include:
- os: windows-2016
- os: windows-2022
sys_pkgs: choco install boost-msvc-14.1
build_unit_test: make.cmd -t -g "Visual Studio 15 2017 Win64"
build_reg_test: make.cmd -g "Visual Studio 15 2017 Win64"
build_unit_test: make.cmd /g "Visual Studio 17 2022" /A "x64" /t
build_reg_test: make.cmd /g "Visual Studio 17 2022" /A "x64"
before_reg_test: before-nrtest.cmd
run_reg_test: run-nrtests.cmd
run_reg_test: run-nrtests.cmd
build_id: "%GITHUB_RUN_ID%_%GITHUB_RUN_NUMBER%"
experimental: false
artifacts_ext: zip
Expand All @@ -38,12 +38,12 @@ jobs:
shell: cmd
working-directory: ./ci-tools/windows

- os: ubuntu-16.04
- os: ubuntu-20.04
sys_pkgs: sudo apt install libboost-dev libboost-all-dev
build_unit_test: make.sh -t -g "Unix Makefiles"
build_reg_test: make.sh -g "Unix Makefiles"
build_unit_test: make.sh -s -t -g "Unix Makefiles"
karosc marked this conversation as resolved.
Show resolved Hide resolved
build_reg_test: make.sh -s -g "Unix Makefiles"
before_reg_test: before-nrtest.sh
run_reg_test: run-nrtests.sh
run_reg_test: run-nrtests.sh
build_id: ${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}
experimental: true
artifacts_ext: tar.gz
Expand All @@ -56,9 +56,9 @@ jobs:
- os: macos-10.15
sys_pkgs: brew install libomp boost
build_unit_test: make.zsh -t -g "Xcode"
build_reg_test: make.zsh -g "Xcode"
build_reg_test: make.zsh -g "Xcode"
before_reg_test: before-nrtest.zsh
run_reg_test: run-nrtests.zsh
run_reg_test: run-nrtests.zsh
build_id: ${GITHUB_RUN_ID}_${GITHUB_RUN_NUMBER}
experimental: true
artifacts_ext: tar.gz
Expand All @@ -80,7 +80,6 @@ jobs:
BUILD_HOME: build
TEST_HOME: nrtests


steps:
- name: Checkout repo
uses: actions/checkout@v2
Expand Down Expand Up @@ -114,7 +113,7 @@ jobs:
- name: Before reg test
env:
NRTESTS_URL: https://github.com/OpenWaterAnalytics/swmm-nrtestsuite
BENCHMARK_TAG: v1.0.4-dev
BENCHMARK_TAG: v2.0.1
run: ./${{ matrix.before_reg_test }} ${{ env.BENCHMARK_TAG }}

- name: Run reg test
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ set(CONFIG_DIST "cmake")
# Define build options
option(BUILD_TESTS "Build component tests (requires Boost)" OFF)
option(BUILD_DOCS "Build toolkit docs (requires Doxygen)" OFF)

option(BUILD_SHARED_LIBS "Build using shared libraries" ON)
karosc marked this conversation as resolved.
Show resolved Hide resolved

# Add project subdirectories
if(BUILD_DOCS)
Expand Down
3 changes: 1 addition & 2 deletions src/outfile/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,7 @@ set(SWMM_OUT_PUBLIC_HEADERS


# the binary output file API
add_library(swmm-output
SHARED
add_library(swmm-output
swmm_output.c
errormanager.c
)
Expand Down
6 changes: 2 additions & 4 deletions src/solver/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,15 @@ if(BUILD_DEF)
PROPERTIES_HEADER_FILE_ONLY TRUE
)

add_library(swmm5
SHARED
add_library(swmm5
${SWMM_SOURCES}
${PROJECT_SOURCE_DIR/bindings/swmm5.def}
$<TARGET_OBJECTS:shared_objs>
)

else()
# Performs standard library build
add_library(swmm5
SHARED
add_library(swmm5
${SWMM_SOURCES}
$<TARGET_OBJECTS:shared_objs>
)
Expand Down