Issue 5486 null markers #5529
Merged
Issue 5486 null markers #5529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
approved these changes
Dec 9, 2022
vilmibm
pushed a commit
to internetarchive/fatcat-scholar
that referenced
this pull request
Feb 16, 2024
with pipenv 2022.11.30, `null` marker could be generated, which would fail other tools; this issue has been tracked under pypa/pipenv#5529 and merged; current lockfile generated with 2023.2.18 ``` ... File "/builds/webgroup/fatcat-scholar/.venv/lib/python3.8/site-packages/packaging/_tokenizer.py", line 163, in raise_syntax_error raise ParserSyntaxError( pip._vendor.packaging._tokenizer.ParserSyntaxError: Expected a marker variable or quoted string None ... ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
Fixes #5486
The fix
This checks if the marker has a value before adding it to the lock file.
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.