Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a good message for error described in issue #2846 #2920

Closed
wants to merge 4 commits into from
Closed

Provide a good message for error described in issue #2846 #2920

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0f380b3
Provide a good message for error described in issue #2846
Oct 5, 2018
95fb6b8
aborting execution
Oct 6, 2018
53333aa
Merge branch 'master' into fix#2846-good-error-message
jr7square Oct 6, 2018
e5da58b
Merge branch 'master' into fix#2846-good-error-message
techalchemy Oct 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pipenv/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1675,6 +1675,9 @@ def do_install(
# Don't search for requirements.txt files if the user provides one
if requirements or package_args or project.pipfile_exists:
skip_requirements = True
# Don't attempt to install develop and default packages if Pipfile is missing
if not project.pipfile_exists and not packages and dev:
click.echo("Could not find Pipfile.", err=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it abort here? This implementation would emit the error, but still carry on to execute the code afterwards.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, I believe it should. Will fix it.

concurrent = not sequential
# Ensure that virtualenv is available.
ensure_project(
Expand Down