Provide a good message for error described in issue #2846 #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
reviewed
Oct 5, 2018
| @@ -1675,6 +1675,9 @@ def do_install( | |||
| # Don't search for requirements.txt files if the user provides one | |||
| if requirements or package_args or project.pipfile_exists: | |||
| skip_requirements = True | |||
| # Don't attempt to install develop and default packages if Pipfile is missing | |||
| if not project.pipfile_exists and not packages and dev: | |||
| click.echo("Could not find Pipfile.", err=True) | |||
There was a problem hiding this comment.
Should it abort here? This implementation would emit the error, but still carry on to execute the code afterwards.
There was a problem hiding this comment.
oh yes, I believe it should. Will fix it.
Closed
techalchemy
added a commit
that referenced
this pull request
Oct 30, 2018
…o merge-prs - Closes #2920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Issue #2846
The fix
Implemented fix with suggestions made to previous PR #2853