Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Python 3.14 #13138

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Jan 2, 2025

This PR is to run tests for Python 3.14, but not to explicitly support Python 3.14.

I think the earlier we add this the better, as if there's some breaking change in 3.14 that we think shouldn't be breaking it might need to be reported before the CPython beta (i.e. feature freeze).

However, I'm just leaving this as draft for now until I know if there is non-trivial work to do to pass the tests on 3.14.

@notatallshaw
Copy link
Member Author

notatallshaw commented Jan 2, 2025

Seems like most the failures on 3.14 are related to the number of /s that should be at the begining of a path, see previous #13105 and #13062 (comment)

@hroncok
Copy link
Contributor

hroncok commented Jan 6, 2025

Seems like most the failures on 3.14 are related to the number of /s that should be at the begining of a path, see previous #13105 and #13062 (comment)

See python/cpython#125974

@hroncok
Copy link
Contributor

hroncok commented Jan 6, 2025

url = urllib.parse.urljoin("file:", urllib.request.pathname2url(path))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants