-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace whitespace in file://
with %20
#214
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
=======================================
Coverage 96.99% 96.99%
=======================================
Files 10 10
Lines 1431 1432 +1
=======================================
+ Hits 1388 1389 +1
Misses 43 43 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Richard Si <sichard26@gmail.com>
Yeah... so writing unit tests when any of the stdlib path <-> URL translation functions are involved is a pain. The number of leading slashes (and even the presence) of the leading slash is platform and Python version dependant. See also pypa/pip#13138 (comment) |
Loooool 😭😂 This single space is taking too many hours 😆 |
Honestly, if you want, you can fall back to escaping only spaces if you assume people won't really be using nonstandard paths. I don't contribute to your project, so if you think it's not worth the testing effort to properly translate paths to URLs, that is your choice :) |
Right, I just reverted to that. Once this issue appears again I will know how to fix it, however, that day might never come, haha. Thanks again! |
Closes #211
Thanks to @ichard26 in pypa/pip#13139 (comment)
cc @dustin-dawind
📚 Documentation preview 📚: https://unidep--214.org.readthedocs.build/en/214/