Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove external (non-core-python) library argparse as a dependency #28

Closed
sugatoray opened this issue Apr 18, 2022 · 4 comments
Closed

Comments

@sugatoray
Copy link

sugatoray commented Apr 18, 2022

Describe the bug

The current dependencies include installing an external library: argparse.

It must be noted that argparse is a part of the core python libraries. There is no need for installing it alike other external libraries.

🔥 EDIT: The library (argparse) that you are installing from PyPI is no longer maintained as it is now a part of standard python3. See my comment here.

See further details:

argparse>=1.4.0
numpy>=1.19.4
scikit-learn>=0.22.1
scipy>=1.5.2
setuptools>=50.3.1.post20201107

@yzhao062
Copy link
Member

thanks @sugatoray ! We are aware of this and suggest keeping it. Our next few releases will roll out some more usages by CLI, and argparse is needed in that scenario.

@sugatoray
Copy link
Author

@yzhao062 So, this library argparse is kept by design then? I wondered if it was there by mistake.

What is the difference between this and core-python argparse?

Thank you.

@kayzliu
Copy link
Member

kayzliu commented Apr 19, 2022

@yzhao062 So, this library argparse is kept by design then? I wondered if it was there by mistake.

What is the difference between this and core-python argparse?

Thank you.

I see the problem. We will remove the argparse in requirement before next release. Thanks! 😊

@sugatoray
Copy link
Author

sugatoray commented Apr 21, 2022

The following is from the README file of the source of PyPI version of argparse library. Since argparse is now a part of core-python (since 2015), it is best to remove the argparse from the requirements.txt.

image

argparse>=1.4.0
numpy>=1.19.4
scikit-learn>=0.22.1
scipy>=1.5.2
setuptools>=50.3.1.post20201107

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants