Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pygod as a package. #18663

Merged
merged 8 commits into from
Apr 19, 2022
Merged

Added pygod as a package. #18663

merged 8 commits into from
Apr 19, 2022

Conversation

thewchan
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pygod) and found it was in an excellent condition.

@sugatoray
Copy link
Contributor

@jaimergp
Copy link
Member

I think it's ok to skip pip check here, either by commenting it out or adding a || true construct.

@thewchan
Copy link
Contributor Author

@jaimergp @sugatoray @conda-forge/staged-recipes I think this is ready for review; the window build fails due to a torch dependency, I can drop that one too if you all think appropriate

- pygod.models
- pygod.utils
commands:
- pip list | grep -E "{{ name }}\s+{{ version }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this. Leaving the pip check commented out is fine. That will help us remember to re-enable it when upstream is fixed.

@ocefpaf ocefpaf merged commit fc5ed53 into conda-forge:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants