Townsend snow (building on #1251) #1468
Conversation
Several other small changes - variable names change, comment change - in response to Kevin's review notes
…ownsend_snow_loss
There was a problem hiding this comment.
Thanks @reepoi this is looking pretty good! A few comments below.
There was a problem hiding this comment.
One or two things below that should be addressed before merging.
A comment more about the model than this PR: the geometry of the ground interference term seem strange to me in that it's only accounting for half of what I would expect from a snow pile. I expected the pile to be symmetrical (angle of repose on both sides), but I can only get the math to match the reference if one side of the pile is vertical. Is the idea that the forward momentum of the shedded snow allows it to populate only the "forward" half of the pile? To be explicit using the labels in my diagram below, I expected the dissipation area to comprise A_1, A_2, and their reflected counterparts on the other side of the "drop height" line, but it seems that Townsend & Powers don't count the reflected counterparts.
|
A communication with the model author T. Townsend: "the pile of snow was modeled as a triangle atop a rectangle, with yes, a vertical wall on the "north" side of the pile. This assumption, while an engineering approximation, is based on observing the shape of shedded snow piles, piles that are shaped by the slight forward (i.e., southward) velocity of the sliding/falling snow and ice." |
There was a problem hiding this comment.
Thanks @abhisheksparikh for getting this started and @reepoi for finishing it! Great to see this merged.
This builds off of pull request #1251 to add the changes suggested in the conversation there and wrap it up.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).