-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* first experimental commit * Added numpy array support * changed var names * changed townsend_Se to private * removed snow.loss_townsend in api.rst * added loss_townsend description in effects_on_pv_system_output.rst * fixed stickler checks * removed rounding of loss and changed to 0-1 range Several other small changes - variable names change, comment change - in response to Kevin's review notes * implementing changes suggested in PR #1251 * removing new line * removing new line * remove new line * Se to effective_snow * adding PR number to whatsnew * address stickler line too long * remove links and noqa E501, and fix long lines * converting to metric system * poa_global from kWh/m2 to Wh/m2 * changing returned loss from kWh to Wh * fixing capacity loss calculation units to keep correct C1 value * convert relative humidity from percent to fraction * neatening docstrings and adjusting variable names * changing eqn 3 percentage loss to fractional loss and adding comment explanation Co-authored-by: Abhishek Parikh <abhishek.parikh2@dnv.com> Co-authored-by: abhisheksparikh <abhi.parikh305@gmail.com>
- Loading branch information
1 parent
ac2cb4b
commit 875aa10
Showing
4 changed files
with
176 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters