Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging tests jasmine #917

Merged
merged 4 commits into from
Oct 24, 2016
Merged

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Oct 24, 2016

Seeing if changes in #916 have solved issues in new Jasmine tests that had been failing.

  • all tests pass -- rake test:all
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request is descriptively named with #number reference back to original issue
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

@jywarren jywarren force-pushed the tagging-tests-jasmine branch from 7bd034f to 49d7a9f Compare October 24, 2016 15:02
@jywarren
Copy link
Member Author

Also closes #916!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant