Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tag deletion works but requires page refresh #801

Closed
jywarren opened this issue Sep 7, 2016 · 2 comments
Closed

tag deletion works but requires page refresh #801

jywarren opened this issue Sep 7, 2016 · 2 comments
Assignees
@david-days
Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute JavaScript

Comments

@jywarren
Copy link
Member

jywarren commented Sep 7, 2016

What happened just before the problem occurred

I deleted a tag, like on this page: https://publiclab.org/wiki/kits#Tags

Tagging deletion triggers a jQuery event called ajax:success which is handled here: https://github.com/publiclab/plots2/blob/master/app/assets/javascripts/tagging.js#L51-L55

but doesn't seem to work; needs some debugging. I think that has to go inside this block: https://github.com/publiclab/plots2/blob/master/app/assets/javascripts/tagging.js#L25

and use tag.id instead of tid. We should also grey out the tag while the request is pending, using a different event:

https://api.jquery.com/Ajax_Events/
@jywarren jywarren added bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute JavaScript labels Sep 7, 2016
jywarren added a commit to jywarren/plots2 that referenced this issue Sep 13, 2016
@jywarren
initial tag debug fixing publiclab#801
2c488e0
jywarren added a commit to jywarren/plots2 that referenced this issue Sep 13, 2016
@jywarren
initial tag debug fixing publiclab#801
892c7ff
@jywarren
Copy link
Member Author

Fix open in #813, will merge soon.

@david-days david-days self-assigned this Sep 20, 2016
jywarren added a commit to jywarren/plots2 that referenced this issue Oct 13, 2016
@jywarren
initial tag debug fixing publiclab#801
50ecaa2
jywarren added a commit that referenced this issue Oct 13, 2016
@jywarren
initial tag debug fixing #801
6a24cf8
@jywarren
Copy link
Member Author

Solved in #917!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-days david-days

Labels
bug the issue is regarding one of our programs which faces problems when a certain task is executed help wanted requires help by anyone willing to contribute JavaScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jywarren @david-days