Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial pagy install for tag page pagination, to solve will_paginate issues #8326

Merged
merged 4 commits into from
Aug 25, 2020

Conversation

jywarren
Copy link
Member

@jywarren jywarren commented Aug 18, 2020

Fixes #7334 with guidance from https://ddnexus.github.io/pagy/migration-guide

@Tlazypanda check out https://github.com/ddnexus/pagy - it makes a strong case that this gem is vastly more efficient for pagination, and i wonder if this will help us overall on performance. Testing on this route first.

https://ddnexus.github.io/pagy/index

@gitpod-io
Copy link

gitpod-io bot commented Aug 18, 2020

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #8326 into main will increase coverage by 0.70%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8326      +/-   ##
==========================================
+ Coverage   81.28%   81.98%   +0.70%     
==========================================
  Files         101      101              
  Lines        5872     5902      +30     
==========================================
+ Hits         4773     4839      +66     
+ Misses       1099     1063      -36     
Impacted Files Coverage Δ
app/controllers/spam2_controller.rb 71.84% <83.33%> (+10.30%) ⬆️
app/controllers/batch_controller.rb 90.19% <100.00%> (+22.23%) ⬆️
app/controllers/home_controller.rb 98.38% <100.00%> (ø)
app/controllers/tag_controller.rb 81.45% <100.00%> (+0.05%) ⬆️
app/helpers/application_helper.rb 84.70% <100.00%> (+0.18%) ⬆️
app/models/node.rb 91.37% <100.00%> (+0.18%) ⬆️
app/models/tag.rb 97.53% <100.00%> (+0.06%) ⬆️
app/api/srch/search.rb 70.06% <0.00%> (+3.82%) ⬆️
app/services/execute_search.rb 94.44% <0.00%> (+5.55%) ⬆️
... and 1 more

@jywarren
Copy link
Member Author

OK, looking all right here:

image

I'll push this to unstable!

@jywarren jywarren requested a review from a team as a code owner August 25, 2020 18:29
@jywarren jywarren mentioned this pull request Aug 25, 2020
@jywarren
Copy link
Member Author

Pushed it here! https://unstable.publiclab.org/tag/water-quality

@jywarren
Copy link
Member Author

jywarren commented Aug 25, 2020

Seeing some issues with wiki pages appearing on 2 subsequent pages. Checking on live site to see if that's unique:

https://unstable.publiclab.org/wiki/tag/water-quality shows Tortuga Guardian, Oil and Gas Water Quality, and Simple Water Sensor Platform on page 2 as well: https://unstable.publiclab.org/wiki/tag/water-quality?page=2

(UPDATE: this exists on production too)

@jywarren
Copy link
Member Author

jywarren commented Aug 25, 2020

Also https://unstable.publiclab.org/questions/tag/water-quality shows 2x pagination due to the Answers code, which we should remove. (UPDATE: confirmed this exists on production too.)

@jywarren
Copy link
Member Author

OK, we should be good to merge this. I don't know that it will fix #7334 -- but let's see.

@jywarren jywarren merged commit fa7977e into main Aug 25, 2020
jywarren added a commit that referenced this pull request Aug 25, 2020
@Tlazypanda
Copy link
Collaborator

Hey @jywarren Yess this was on my up-for-discussion list in #7883 ✌️ maybe I should open another pr with some more routes migrated to Pagy 😅

nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
nadimakhtar97 pushed a commit to nadimakhtar97/plots2 that referenced this pull request Sep 21, 2020
@Tlazypanda Tlazypanda mentioned this pull request Sep 24, 2020
8 tasks
@Tlazypanda
Copy link
Collaborator

Linking this work to migrate to pagy issue #8426

@cesswairimu
Copy link
Collaborator

Thanks Sneha 🚀

shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
shubhangikori pushed a commit to shubhangikori/plots2 that referenced this pull request Oct 12, 2020
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
alvesitalo pushed a commit to alvesitalo/plots2 that referenced this pull request Oct 14, 2020
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
piyushswain pushed a commit to piyushswain/plots2 that referenced this pull request Oct 22, 2020
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
manchere pushed a commit to manchere/plots2 that referenced this pull request Feb 13, 2021
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
lagunasmel pushed a commit to lagunasmel/plots2 that referenced this pull request Mar 2, 2021
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
reginaalyssa pushed a commit to reginaalyssa/plots2 that referenced this pull request Oct 16, 2021
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
ampwang pushed a commit to ampwang/plots2 that referenced this pull request Oct 26, 2021
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
…issues (publiclab#8326)

* initial pagy install

* pagy basic functionality

* other node types

* reorder
billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong wiki count in Dropdown by type
3 participants