-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial pagy install for tag page pagination, to solve will_paginate issues #8326
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8326 +/- ##
==========================================
+ Coverage 81.28% 81.98% +0.70%
==========================================
Files 101 101
Lines 5872 5902 +30
==========================================
+ Hits 4773 4839 +66
+ Misses 1099 1063 -36
|
Pushed it here! https://unstable.publiclab.org/tag/water-quality |
Seeing some issues with wiki pages appearing on 2 subsequent pages. Checking on live site to see if that's unique: https://unstable.publiclab.org/wiki/tag/water-quality shows (UPDATE: this exists on production too) |
Also https://unstable.publiclab.org/questions/tag/water-quality shows 2x pagination due to the Answers code, which we should remove. (UPDATE: confirmed this exists on production too.) |
OK, we should be good to merge this. I don't know that it will fix #7334 -- but let's see. |
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
Linking this work to migrate to pagy issue #8426 |
Thanks Sneha 🚀 |
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
…issues (publiclab#8326) * initial pagy install * pagy basic functionality * other node types * reorder
Fixes #7334 with guidance from https://ddnexus.github.io/pagy/migration-guide
@Tlazypanda check out https://github.com/ddnexus/pagy - it makes a strong case that this gem is vastly more efficient for pagination, and i wonder if this will help us overall on performance. Testing on this route first.
https://ddnexus.github.io/pagy/index