Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to pagy #8426

Closed
8 tasks done
Tlazypanda opened this issue Sep 24, 2020 · 5 comments · Fixed by #8599 or #8635
Closed
8 tasks done

Migrate to pagy #8426

Tlazypanda opened this issue Sep 24, 2020 · 5 comments · Fixed by #8599 or #8635
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute Ruby

Comments

@Tlazypanda
Copy link
Collaborator

Tlazypanda commented Sep 24, 2020

Please describe the desired behavior.
Currently we are using will_paginate gem for pagination but pagy offers better performance and saves memory.
Follow up to #8326

https://ddnexus.github.io/pagy/migration-guide
https://github.com/ddnexus/pagy

Implemented routes

wiki

  • stale
  • index
  • revisions
  • author

tag

  • blog
  • show

notes

  • places
  • author
@Tlazypanda Tlazypanda added feature explains that the issue is to add a new feature break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration labels Sep 24, 2020
@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Sep 24, 2020

Hey @jywarren @cesswairimu using this issue as master issue will be adding pagy for different routes in smaller prs 😅 Also document/catch any important bugs here as well 😅

@cesswairimu
Copy link
Collaborator

cool, haven't used pagy before will check it out. Thanks

@jywarren
Copy link
Member

Thank you! Yes, pagy seems to be massively faster... and lower memory usage. I hope this will be really helpful!

@jywarren jywarren added help wanted requires help by anyone willing to contribute Ruby labels Sep 29, 2020
@avats-dev
Copy link
Member

Also, this could be implemented through a lot of ftos or hacktoberfest issues. I think managing this like #6579 would be good too to keep track of remaining changes.

@Tlazypanda
Copy link
Collaborator Author

Tlazypanda commented Sep 30, 2020

Yes, I also think we should create some issues out of this 😅 for hacktoberfest maybe we can maintain the list of functions in which this has been implemented in the issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
break-me-up break up for cleaner code separation, discrete tests, and, easier and iterative collaboration feature explains that the issue is to add a new feature help wanted requires help by anyone willing to contribute Ruby
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants