Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CSS to address issue #5959 #6069

Merged
merged 1 commit into from
Jul 26, 2019

Conversation

enviro3
Copy link
Contributor

@enviro3 enviro3 commented Jul 25, 2019

@welcome
Copy link

welcome bot commented Jul 25, 2019

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

@enviro3
Copy link
Contributor Author

enviro3 commented Jul 25, 2019

@publiclab/reviewers , this is my first time contributing to open source so please feel free to give me feedback. Thanks!

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @enviro3 Can I see the screenshot of the updated change ?

@enviro3
Copy link
Contributor Author

enviro3 commented Jul 26, 2019

Hi @CleverFool77, of course :) Here is a screenshot of what I see visually:
Image 7-26-19 at 8 09 AM

Copy link
Member

@CleverFool77 CleverFool77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The block quotes looks good.
Hi @jywarren
This PR is ready.

@jywarren jywarren merged commit 877b2bd into publiclab:master Jul 26, 2019
@welcome
Copy link

welcome bot commented Jul 26, 2019

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link pinned in the issue section 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

@jywarren
Copy link
Member

Great work! Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error in <blockquote> parsing in Markdown
3 participants