error in <blockquote> parsing in Markdown

[jywarren]

Oddly it looks like markdown blockquotes are getting converted to <p> paragraph tags:

this rendered from the Markdown usage:

> Text here

We may need to look at whether our markdown parser has changed. Oddly the render method in comment.rb hasn't for 4 months, so it seems unlikely to be the issue:

plots2/app/models/comment.rb

Lines 413 to 425 in 61684ae

	def render_body
	body = RDiscount.new(
	title_suggestion(self),
	:autolink
	).to_html
	# if it has quoted email text that wasn't caught by the yahoo and gmail filters,
	# manually insert the comment filter delimeter:
	parsed = parse_quoted_text
	if !trimmed_content? && parsed.present?
	body = parsed[:body] + COMMENT_FILTER + parsed[:boundary] + parsed[:quote]
	end
	body
	end

This needs some further investigation and we might also link to #3889 !

cc @ebarry

[jywarren]

Ah, wait! The blockquote code is there, so this is a styling issue!

Great. So let's check our CSS.

[jywarren]

So it'll be in one of these; probably the first! We can check if they've changed, OR we can check if the container for comments has changed and is no longer getting these styles applied:

plots2/app/assets/stylesheets/comments.css

Lines 27 to 32 in a3e40c5

	.blockquotestyle > blockquote {
	font-size: 14px;
	font-family: "Helvetica Neue";
	border-left: 5px solid #736f6f;
	background-color: #f3f1ef;
	}

plots2/app/assets/stylesheets/style.css

Lines 286 to 289 in 63090da

	.pl-content blockquote p {
	padding: 8px 4px;
	margin-top: 8px;
	}

[jywarren]

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

[enviro3]

Hi @jywarren, I'm a newbie and would love to take a shot at this issue. May I work on this?

[rexagod]

Go ahead, @enviro3!