System test for drag to upload image in comment form

[jywarren]

Re: #5229

[plotsbot]

	1 Message
📖	@jywarren Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[jywarren]

Selenium::WebDriver::Error::UnknownError:         Selenium::WebDriver::Error::UnknownError: unknown error: path is not absolute: public/images/pl.png
          (Session info: headless chrome=74.0.3729.157)

[jywarren]

rails aborted!
SyntaxError: /app/test/system/comment_upload_test.rb:15: syntax error, unexpected ',', expecting ')'
t.to_s}/public/images/pl.png", false)

[jywarren]

ERROR["test_uploading_by_dragging", #<Minitest::Reporters::Suite:0x0000560da661a738 @name="CommentUploadTest">, 367.67084992700006]
 test_uploading_by_dragging#CommentUploadTest (367.67s)
Selenium::WebDriver::Error::JavascriptError:         Selenium::WebDriver::Error::JavascriptError: javascript error: fileList is not defined
          (Session info: headless chrome=74.0.3729.157)
          (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.4.0-101-generic x86_64)
            test/system/comment_upload_test.rb:35:in `drop_in_dropzone'
            test/system/comment_upload_test.rb:15:in `block in <class:CommentUploadTest>'

[jywarren]

hmm, now:

 FAIL["test_viewing_the_dashboard", #<Minitest::Reporters::Suite:0x000055d036d2a5f8 @name="DashboardTest">, 322.3365901269999]
 test_viewing_the_dashboard#DashboardTest (322.34s)
        expected to find visible css ".row.header > h1" with text "Dashboard" but there were no matches. Also found "Community research", which matched the selector but not all filters. 
        test/system/dashboard_test.rb:19:in `block in <class:DashboardTest>'
[Screenshot]: tmp/screenshots/failures_test_uploading_by_dragging.png
ERROR["test_uploading_by_dragging", #<Minitest::Reporters::Suite:0x00007ffaf958f5b0 @name="CommentUploadTest">, 325.9385120889999]
 test_uploading_by_dragging#CommentUploadTest (325.94s)
Selenium::WebDriver::Error::JavascriptError:         Selenium::WebDriver::Error::JavascriptError: javascript error: Cannot read property 'listeners' of undefined
          (Session info: headless chrome=74.0.3729.157)
          (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.4.0-101-generic x86_64)
            test/system/comment_upload_test.rb:32:in `drop_in_dropzone'
            test/system/comment_upload_test.rb:15:in `block in <class:CommentUploadTest>'

[jywarren]

I think this is actually because JavaScript methods aren't waiting for selectors to find things... so i'm going to insert a assert_selector() to get it to wait.

[jywarren]

If this doesn't work, we might try to do a jQuery.ready(... kind of thing

[jywarren]

https://gist.github.com/kyleroberthammond/a544e0a4ee5f6380b6a22698fb585ba6

https://stackoverflow.com/questions/36558682/dropzone-capybara-upload-image-cucumber-javascript

[jywarren]

ERROR["test_uploading_by_dragging", #<Minitest::Reporters::Suite:0x0000556429c29060 @name="CommentUploadTest">, 75.03885131300001]
 test_uploading_by_dragging#CommentUploadTest (75.04s)
Selenium::WebDriver::Error::JavascriptError:         Selenium::WebDriver::Error::JavascriptError: javascript error: Cannot read property 'listeners' of undefined
          (Session info: headless chrome=74.0.3729.157)
          (Driver info: chromedriver=74.0.3729.6 (255758eccf3d244491b8a1317aa76e1ce10d57e9-refs/branch-heads/3729@{#29}),platform=Linux 4.4.0-101-generic x86_64)
            test/system/comment_upload_test.rb:34:in `drop_in_dropzone'
            test/system/comment_upload_test.rb:17:in `block in <class:CommentUploadTest>'

[jywarren]

OK, still not waiting to instantiate the function...

[VladimirMikulic]

@jywarren this can be closed #7255 resolves this also. (image drag and drop)

[jywarren]

Great!!!