List of system tests to implement

[kaustubh-nair]

I thought of making a list of system tests to be written so that it's easier to test javascript features that aren't covered properly.

• Test if dashboard map is getting loaded
• Test if leaflet layer is loading properly for map creation
• Test annotations ( break me up )
• Test search
• Test image upload
• Test image placement
• Test drag to upload ( This is a difficult one similar to this System test for drag to upload image in comment form plots2#5655 )

[kaustubh-nair]

I'll implement some of these, but if you're a newcomer you can grab an easy one and test it too!
Here's an example of a system test if you need reference: https://github.com/publiclab/mapknitter/blob/main/test/system/images_test.rb

[kaustubh-nair]

Also, @publiclab/mapknitter-reviewers: feel free to add more to the list

[alaxalves]

Great idea @kaustubh-nair !!

[SidharthBansal]

Great idea. Is this for your project or generic?

…

On Sat, Aug 31, 2019, 1:29 AM Álax de Carvalho Alves < ***@***.***> wrote: Great idea @kaustubh-nair <https://github.com/kaustubh-nair> !! — You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub <#967?email_source=notifications&email_token=AFAAEQ4TU6SKVDWNAL4JBMDQHF33RA5CNFSM4IPJEQEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SUDFA#issuecomment-526729620>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQ665XIG7E2JXNOVYSTQHF33RANCNFSM4IPJEQEA> .

[kaustubh-nair]

@SidharthBansal This is open for anyone to write. I can help them out in case there are any issues with the tests. I haven't implemented them myself since I'm not much familiar with LDI

[SidharthBansal]

No problem. Thanks for opening this issue.

…

On Sun, Sep 1, 2019, 2:43 PM Kaustubh Nair ***@***.***> wrote: @SidharthBansal <https://github.com/SidharthBansal> This is open for anyone to write. I can help them out in case there are any issues with the tests. I haven't implemented them myself since I'm not much familiar with LDI — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#967?email_source=notifications&email_token=AFAAEQ3YHJ24XQXFSRVHCMTQHOBTDA5CNFSM4IPJEQEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5T6CGI#issuecomment-526901529>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFAAEQZ42QZAETTJ72UX7XLQHOBTDANCNFSM4IPJEQEA> .

[coderjolly]

Great Idea @kaustubh-nair

[cesswairimu]

Hey @kaustubh-nair , was just checking if you have some time to break some of these issues into small issues that can be solved as gci tasks? No worries if you are busy just checking :)

[kaustubh-nair]

Sure @cesswairimu , no problem
I'll do that!

[cesswairimu]

Thanks

[chepyego]

hey can i work on this or it is closed?

[chepyego]

I think it is still on let me see then work on it