change deliver_now to deliver_later in answer_like_controller

[AnthoniaOkafor]

Fixes #5311 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• PR is descriptively titled 📑 and links the original issue above 🔗
• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts 📁
• screenshots/GIFs are attached 📎 in case of UI updation
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[AnthoniaOkafor]

@publiclab/plots2-reviewers kindly see my PR

[plotsbot]

	1 Message
📖	@AnthoniaOkafor Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.

Generated by 🚫 Danger

[grvsachdeva]

Hey @AnthoniaOkafor, this test https://github.com/publiclab/plots2/blob/master/test/functional/notes_controller_test.rb#L279-L296 is failing so wrap up the code in perform_enqueued_jobs like mentioned here - #5311 (comment)

Thanks!

[AnthoniaOkafor]

Hello @gauravano, I have wrapped the code in test/functional/answer_like_controller_test.rb with
'perform_enqueued_jobs do', but the Travis Cl build for my PR is still failing.

[AnthoniaOkafor]

Hey @AnthoniaOkafor, this test https://github.com/publiclab/plots2/blob/master/test/functional/notes_controller_test.rb#L279-L296 is failing so wrap up the code in perform_enqueued_jobs like mentioned here - #5311 (comment)

Thanks!

Hello @gauravano, for the answer_like controller I am working on, you want me to wrap the code in https://github.com/publiclab/plots2/blob/master/test/functional/notes_controller_test.rb#L279-L296 with 'perform_enqueued_jobs do'. I thought it was a mistake so wrapped the code in test/functional/answer_like_controller_test.rb. If you say so, I can restore answer_like_controller_test.rb and change notes_controller_test.rb#L279-L296 instead.

[grvsachdeva]

Hey @AnthoniaOkafor, first of all, let's remove changes from answer_like_controller_test as we are not checking any email sending there so no need of it there.

After that, let's see if we encounter the error again as I am not getting the error when running the individual test file. Thanks!

[AnthoniaOkafor]

@publiclab/reviewers please see my PR

[jywarren]

Great, thank you!!!