(not working yet) Change deliver_now to deliver_later for all emails

[jywarren]

We just successfully converted the admin_controller to use deliver_later to enqueue email sending, which should really help keep the website running smoother -- it uses Redis automatically to send emails on another thread.

https://github.com/publiclab/plots2/pull/4967/files shows how we did it -- it did involve wrapping all failing tests with:

perform_enqueued_jobs do 
  # all test contents
end

Let's do this for each controller, and each time we use deliver_now -- you can find all instances using this search:

https://github.com/publiclab/plots2/search?q=deliver_now

We'd love help with this, and it's fine for it to be over a series of pull requests, one at a time!

• users_controller (@divyabaid16)
• answer_like_controller(@AnthoniaOkafor)
• notes_controller
• user_sessions_controller
• answers_controller
• admin_controller

[divyabaid16]

Can I work on this?

[namangupta01]

Go ahead

…

On Mon, 1 Apr 2019, 09:09 Divya Baid, ***@***.***> wrote: Can I work on this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5311 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ATwCYRY_c4IwGS5Vgl7kzf5tXYiBlnS3ks5vcX9VgaJpZM4cT1Xh> .

[divyabaid16]

Hi! I had a small confusion. I wanted to know whether I should change it for each controller only?
Or do I need to change the test so that the tests do not fail?

[AnthoniaOkafor]

@jywarren @namangupta01 please can I have an fto_candidate issue on Ruby. Thanks

[divyabaid16]

@AnthoniaOkafor if you want you can solve this issue for any controller.
Thanks!

[AnthoniaOkafor]

Ok, I will. Thanks

[jywarren]

Just a note that we don't seem to be seeing these emails sent when using `deliver_later` and are still debugging this... we'd love the PRs but are probably not going to merge them until we finish debugging it! But thanks for the help!!!

…

On Tue, Apr 30, 2019 at 8:45 AM Gaurav Sachdeva ***@***.***> wrote: Closed #5311 <#5311> via #5451 <#5451>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5311 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAF6J4OBEXCWFGDS2AKP53PTA5FBANCNFSM4HCPKXQQ> .

[jywarren]

OK, we are seeing these deliver_later pile up in sidekiq!

https://publiclab.org/sidekiq/queues/mailers

[jywarren]

So, I think this may actually be all good, but just we're never actually triggering the job.

https://api.rubyonrails.org/classes/ActionMailer/MessageDelivery.html#method-i-deliver_later

OK, more on this here: https://stackoverflow.com/a/51642031

We need: config.active_job.queue_adapter = :sidekiq

https://gist.github.com/maxivak/690e6c353f65a86a4af9#configure-sidekiq

I'm not sure if config.action_mailer.perform_deliveries = true is necessary...

Trying the rest, meaning also a config/sidekiq.yml in #5687

[jywarren]

If it passes, i'll merge into stable, and we can publish along with the big Bootstrap upgrade; we'll see how it does in production, since these emails are not critical!

[jywarren]

Also good docs: https://blog.morizyun.com/ruby/library-sidekiq-job-queue-active-job.html

[jywarren]

Confirmed! With the code publication we did tonight, this deliver_later system is now working! We can start the rest of the controller conversions now. 🎉