Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to main stats page on tag stats page #5007

Merged
merged 1 commit into from
Mar 11, 2019
Merged

link to main stats page on tag stats page #5007

merged 1 commit into from
Mar 11, 2019

Conversation

gautamig54
Copy link
Contributor

@gautamig54 gautamig54 commented Mar 11, 2019

Fixes #5001
Screen Shot 2019-03-11 at 2 46 18 AM
(<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • PR is descriptively titled 📑
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@plotsbot
Copy link
Collaborator

2 Messages
📖 @gautamig54 Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progress’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@gautamig54 gautamig54 changed the title link to main stats page ontag stats page link to main stats page on tag stats page Mar 11, 2019
@grvsachdeva grvsachdeva requested a review from cesswairimu March 11, 2019 12:34
Copy link
Member

@grvsachdeva grvsachdeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@grvsachdeva
Copy link
Member

@cesswairimu let me know if you think it's ready to merge. Thanks!

Copy link
Member

@avsingh999 avsingh999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @gauravano its ready to merge. Good job @gautamig54 🎈

@jywarren jywarren merged commit 52542f4 into publiclab:master Mar 11, 2019
@jywarren
Copy link
Member

🎉 thank you!!!!

divyabaid16 pushed a commit to divyabaid16/plots2 that referenced this pull request Mar 11, 2019
@grvsachdeva
Copy link
Member

@gautamig54 we would love to have more help from you. You can start working on help-wanted issues from - https://github.com/publiclab/plots2/issues, if interested. Thanks!

icarito pushed a commit to icarito/plots2 that referenced this pull request Apr 9, 2019
SrinandanPai pushed a commit to SrinandanPai/plots2 that referenced this pull request May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants