Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to main stats page on tag stats page #5001

Closed
5 tasks
cesswairimu opened this issue Mar 10, 2019 · 2 comments
Closed
5 tasks

Link to main stats page on tag stats page #5001

cesswairimu opened this issue Mar 10, 2019 · 2 comments
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it
Milestone

Comments

@cesswairimu
Copy link
Collaborator

cesswairimu commented Mar 10, 2019

Created specifically for @gautamig54

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

Update
After line https://github.com/publiclab/plots2/blob/master/app/views/tag/stats.html.erb#L2, add

<h3> Tag statistics for <%= @tags.first.name %> </h3>
<hr>
<%= link_to " See statistics for all contents", stats_path %>

After changing the view, also attach the screenshot of updated view in the PR.

  • 💾 Commit your changes

  • 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

@cesswairimu cesswairimu added the first-timers-only They need to be well-formatted using the First-timers_Issue_Template. label Mar 10, 2019
@gautamig54
Copy link
Contributor

@cesswairimu thanks! I will start working in this issue :)

@gautamig54
Copy link
Contributor

I have created a PR solving this issue.

@grvsachdeva grvsachdeva added the has-pull-request issues which already have a pull request solving it label Mar 11, 2019
@ebarry ebarry added this to the Metrics milestone Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-timers-only They need to be well-formatted using the First-timers_Issue_Template. has-pull-request issues which already have a pull request solving it
Projects
None yet
Development

No branches or pull requests

4 participants