Added unit tests for outlook reply by email

[oorjitchowdhary]

I'm a GCI-candidate.
Fixes #3436 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[oorjitchowdhary]

@publiclab/reviewers This is the unit tests for outlook reply by email feature #3426 which I solved in PR #4045

[plotsbot]

	2 Messages
📖	@oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖	It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

[namangupta01]

Please Don't copy the google email and yahoo email tests. They are not going to work. Tests for outlook is way much different from Gmail and Yahoo. To test the reply by email from outlook correctly firstly, you have to set up mailman on your system with the proper configuration and then create a user with the outlook email on your local system. After that add the implementation for parsing the emails coming from the outlook just like Gmail and Yahoo. Then send the email from the yahoo email to the email you have set up in mailman configuration and then check if the comment and answer is added to the correct node with the correct reply that you have sent in the email. This is gonna take time so please dont get discourage. Do some research over how mailman works and let me know if you need some help.
Thanks

[oorjitchowdhary]

Please Don't copy the google email and yahoo email tests. They are not going to work. Tests for outlook is way much different from Gmail and Yahoo. To test the reply by email from outlook correctly firstly, you have to set up mailman on your system with the proper configuration and then create a user with the outlook email on your local system. After that add the implementation for parsing the emails coming from the outlook just like Gmail and Yahoo. Then send the email from the yahoo email to the email you have set up in mailman configuration and then check if the comment and answer is added to the correct node with the correct reply that you have sent in the email. This is gonna take time so please dont get discourage. Do some research over how mailman works and let me know if you need some help.
Thanks

Ohh Okay... Can you please tell me how can i setup mailman on my local machine..

[oorjitchowdhary]

Also.. where should I add the implementation for parsing of emails.... Can I get a pointer on that..

[oorjitchowdhary]

@namangupta01

[digitaldina]

@oorjitchowdhary you will most likely get a quicker answer if you check out the IRC or the Glitch

[SidharthBansal]

@jywarren can you please review it.

[jywarren]

So this file should be a complete reply email generated by Outlook, which you can use to base the tests around. if you replace this content with an email generated by Outlook in reply to another email, we can restructure the code around parsing an Outlook-style email so that the "quoted text" does not appear in comments. Does that make sense?

[jywarren]

Actually @dinaelhanan this one is not quite ready - thanks for your help in labeling! But perhaps if it's not very clearly ready (say, you can personally confirm that code works properly OR someone has posted a new commit or comment completely addressing a prior review, maybe?) then perhaps hold off on the 'ready' label? Thanks so much!

[SidharthBansal]

@dinaelhanan here are a few supportive non beginner tasks which I created recently as per your request

https://codein.withgoogle.com/dashboard/tasks/5464186466336768/
https://codein.withgoogle.com/dashboard/tasks/6406765190053888/

[digitaldina]

@SidharthBansal thanks! I will definelty take them up. Just waiting on this approval:
https://codein.withgoogle.com/dashboard/task-instances/4824240835526656/

[digitaldina]

@jywarren thanks for pointing that out! I've learned through another mistake on another issue that I should only label PR as ready if they have been reviewed and all checks have passed. Will use that more appropriately next time. Thanks!

[SidharthBansal]

Great

[jywarren]

Hi @oorjitchowdhary ! I've just merged in this, and perhaps you could ask @kevinzluo if there is more to do here or if you might be able to help with more tests. If not, perhaps we should close this? Thank you!!!