Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reply by email feature for outlook #4045

Closed
wants to merge 0 commits into from
Closed

Added reply by email feature for outlook #4045

wants to merge 0 commits into from

Conversation

oorjitchowdhary
Copy link
Member

@oorjitchowdhary oorjitchowdhary commented Nov 26, 2018

I'm a GCI-candidate.
Fixes #3426 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@oorjitchowdhary
Copy link
Member Author

@publiclab/reviewers Please review ...
Codeclimate is failing due to the duplicate elsif code at various locations which was already there. I just added another one for outlook.

@plotsbot
Copy link
Collaborator

plotsbot commented Nov 26, 2018

3 Messages
📖 @oorjitchowdhary Thank you for your pull request! I’m here to help with some tips and recommendations. Please take a look at the list provided and help us review and accept your contribution! And don’t be discouraged if you see errors – we’re here to help.
📖 Your pull request is on the master branch. Please make a separate feature branch) with a descriptive name like new-blog-design while making PRs in the future.
📖 It looks like you haven’t marked all the checkboxes. Help us review and accept your suggested changes by going through the steps one by one. If it is still a ‘Work in progresss’, please include ‘[WIP]’ in the title.

Generated by 🚫 Danger

@@ -328,6 +332,22 @@ def self.gmail_parsed_mail(mail_doc)
}
end

def self.outlook_parsed_mail(mail_doc)
if mail_doc.css(".outlook_quote").any?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is nothing like outlook_quote class in outlook email. And the implementation for reply by email from outlook is different from that of the Gmail and Yahoo. So please don't copy the Gmail and Yahoo mail implementation. Instead, you have to analyze the emails sent by outlook to Gmail and outlook to other emails by converting them to HTML and them extract out how we can separate out the quoted element of the mail and actual reply.
This is a harder issue. It is gonna take some time researching.
Thanks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead, you have to analyze the emails sent by outlook to Gmail and outlook to other emails by converting them to HTML and them extract out how we can separate out the quoted element of the mail and actual reply.

Can you pls explain me this.. I really want to solve this issue...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants