Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the Styling of Woofmark Buttons on pl.org/post #10510

Merged
merged 1 commit into from
Nov 27, 2021

Conversation

Prerna-0202
Copy link
Contributor

@Prerna-0202 Prerna-0202 commented Nov 21, 2021

I have improved the styling of Woofmark Buttons on pl.org/post as per issue #7067

Fixes #7067

Before->
publiclab1
After->
publiclab2

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/reviewers for help, in a comment below

@codeclimate
Copy link

codeclimate bot commented Nov 21, 2021

Code Climate has analyzed commit b0167d8 and detected 0 issues on this pull request.

View more on Code Climate.

@Prerna-0202
Copy link
Contributor Author

@jywarren @VladimirMikulic, Can you please review my pr .and provide me with the feedback...

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Prerna-0202 LGTM 🎉 Can you please add a screenshot as well?

@Prerna-0202
Copy link
Contributor Author

@Tlazypanda, Yaa Sure I will attach a screenshot and Thanks for reviewing my pr...

@Prerna-0202
Copy link
Contributor Author

@Tlazypanda, Can you please tell do I further need to make any changes in this pr??

Copy link
Collaborator

@Tlazypanda Tlazypanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Prerna-0202 Awesome 🎉 Thank you for working on this!

@Tlazypanda Tlazypanda merged commit a7908bc into publiclab:main Nov 27, 2021
@welcome
Copy link

welcome bot commented Nov 27, 2021

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days, but first it will be published to https://stable.publiclab.org/ (it will take some minutes for this to load, and until then you may see logs from the build process). Please test out your work on this testing server and report back with a comment that all has gone well!
Do join our weekly check-in to share your this week goal and the awesome work you did 😃. Please find the link to our latest check-in here 📝
Now that you've completed this, you can help someone else take their first step!
Reach out to someone else working on theirs on Public Lab's code welcome page (where you'll now be featured as a recent contributor!). Thanks!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

billymoroney1 pushed a commit to billymoroney1/plots2 that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the styling of Woofmark buttons on pl.org/post
3 participants