-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved the Styling of Woofmark Buttons on pl.org/post #10510
Conversation
Code Climate has analyzed commit b0167d8 and detected 0 issues on this pull request. View more on Code Climate. |
@jywarren @VladimirMikulic, Can you please review my pr .and provide me with the feedback... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Prerna-0202 LGTM 🎉 Can you please add a screenshot as well?
@Tlazypanda, Yaa Sure I will attach a screenshot and Thanks for reviewing my pr... |
@Tlazypanda, Can you please tell do I further need to make any changes in this pr?? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Prerna-0202 Awesome 🎉 Thank you for working on this!
Congrats on merging your first pull request! 🙌🎉⚡️ Help others take their first stepNow that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌 Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕 People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉 Read about how to help support another newcomer here, or find other ways to offer mutual support here. |
I have improved the styling of Woofmark Buttons on pl.org/post as per issue #7067
Fixes #7067
Before->


After->
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test
@publiclab/reviewers
for help, in a comment below