Upgrade to Rails 6.0.0 #824
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to get this running we'll need a ruby version > 2.5. What's your input on this? @sashadev-sky @jywarren |
|
Hi @alaxalves - @icarito noted that Rails 6 is currently beyond Debian
stable's version, and i was wondering if we should start with a PR that
addresses deprecations and warnings without actually initiating the 6.0
upgrade just yet. Do we have an idea of Debian stable's schedule? I just
want to be careful about this and think well ahead, and I don't quite have
all the info to provide good input yet. Thanks so much!
…On Tue, Jul 9, 2019 at 12:08 PM Álax de Carvalho Alves < ***@***.***> wrote:
Fixes #603 <#603> (<=== Add
issue number here)
Make sure these boxes are checked before your pull request (PR) is ready
to be reviewed and merged. Thanks!
- PR is descriptively titled 📑 and links the original issue above 🔗
- tests pass -- look for a green checkbox ✔️ a few minutes after
opening your PR -- or run tests locally with rake test
- code is in uniquely-named feature branch and has no merge conflicts
📁
- screenshots/GIFs are attached 📎 in case of UI updation
- ask @publiclab/mapknitter-reviewers for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help,
and *don't be discouraged* if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at
https://publiclab.org/contributing-to-public-lab-software
Thanks!
------------------------------
You can view, comment on, or merge this pull request online at:
#824
Commit Summary
- Bumping rails version
File Changes
- *M* Gemfile
<https://github.com/publiclab/mapknitter/pull/824/files#diff-0> (4)
- *M* Gemfile.lock
<https://github.com/publiclab/mapknitter/pull/824/files#diff-1> (131)
Patch Links:
- https://github.com/publiclab/mapknitter/pull/824.patch
- https://github.com/publiclab/mapknitter/pull/824.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=AAAF6J6XGCTGN7NXDOO4KJTP6SZWVA5CNFSM4H7HD3Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6ESRFQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J7RBR5CLPG4LNUPQFLP6SZWVANCNFSM4H7HD3YQ>
.
|
|
Ah, interesting. Would upgrading to Ruby 2.5 be its own PR perhaps, that
could be done before Rails 6?
…On Tue, Jul 9, 2019 at 12:12 PM Jeffrey Warren ***@***.***> wrote:
Hi @alaxalves - @icarito noted that Rails 6 is currently beyond Debian
stable's version, and i was wondering if we should start with a PR that
addresses deprecations and warnings without actually initiating the 6.0
upgrade just yet. Do we have an idea of Debian stable's schedule? I just
want to be careful about this and think well ahead, and I don't quite have
all the info to provide good input yet. Thanks so much!
On Tue, Jul 9, 2019 at 12:08 PM Álax de Carvalho Alves <
***@***.***> wrote:
> Fixes #603 <#603> (<===
> Add issue number here)
>
> Make sure these boxes are checked before your pull request (PR) is ready
> to be reviewed and merged. Thanks!
>
> - PR is descriptively titled 📑 and links the original issue above 🔗
> - tests pass -- look for a green checkbox ✔️ a few minutes after
> opening your PR -- or run tests locally with rake test
> - code is in uniquely-named feature branch and has no merge conflicts
> 📁
> - screenshots/GIFs are attached 📎 in case of UI updation
> - ask @publiclab/mapknitter-reviewers for help, in a comment below
>
> We're happy to help you get this ready -- don't be afraid to ask for
> help, and *don't be discouraged* if your tests fail at first!
>
> If tests do fail, click on the red X to learn why by reading the logs.
>
> Please be sure you've reviewed our contribution guidelines at
> https://publiclab.org/contributing-to-public-lab-software
>
> Thanks!
> ------------------------------
> You can view, comment on, or merge this pull request online at:
>
> #824
> Commit Summary
>
> - Bumping rails version
>
> File Changes
>
> - *M* Gemfile
> <https://github.com/publiclab/mapknitter/pull/824/files#diff-0> (4)
> - *M* Gemfile.lock
> <https://github.com/publiclab/mapknitter/pull/824/files#diff-1> (131)
>
> Patch Links:
>
> - https://github.com/publiclab/mapknitter/pull/824.patch
> - https://github.com/publiclab/mapknitter/pull/824.diff
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#824?email_source=notifications&email_token=AAAF6J6XGCTGN7NXDOO4KJTP6SZWVA5CNFSM4H7HD3Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6ESRFQ>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAAF6J7RBR5CLPG4LNUPQFLP6SZWVANCNFSM4H7HD3YQ>
> .
>
|
Yes, I could open a MR upgrading to latest ruby. BTW can I push Rails 5 to unstable? |
|
for sure push to unstable! Thanks!
On Tue, Jul 9, 2019 at 5:29 PM Álax de Carvalho Alves <
notifications@github.com> wrote:
… Ah, interesting. Would upgrading to Ruby 2.5 be its own PR perhaps, that
could be done before Rails 6?
… <#m_-5784711317799686700_>
On Tue, Jul 9, 2019 at 12:12 PM Jeffrey Warren *@*.*> wrote: Hi
@alaxalves <https://github.com/alaxalves> - @icarito
<https://github.com/icarito> noted that Rails 6 is currently beyond Debian
stable's version, and i was wondering if we should start with a PR that
addresses deprecations and warnings without actually initiating the 6.0
upgrade just yet. Do we have an idea of Debian stable's schedule? I just
want to be careful about this and think well ahead, and I don't quite have
all the info to provide good input yet. Thanks so much! On Tue, Jul 9, 2019
at 12:08 PM Álax de Carvalho Alves < @.*> wrote: > Fixes #603
<#603> <#603
<#603>> (<=== > Add issue
number here) > > Make sure these boxes are checked before your pull request
(PR) is ready > to be reviewed and merged. Thanks! > > - PR is
descriptively titled and links the original issue above > - tests pass --
look for a green checkbox a few minutes after > opening your PR -- or run
tests locally with rake test > - code is in uniquely-named feature branch
and has no merge conflicts > > - screenshots/GIFs are attached in case of
UI updation > - ask @publiclab/mapknitter-reviewers
<https://github.com/orgs/publiclab/teams/mapknitter-reviewers> for help,
in a comment below > > We're happy to help you get this ready -- don't be
afraid to ask for > help, and *don't be discouraged* if your tests fail
at first! > > If tests do fail, click on the red X to learn why by reading
the logs. > > Please be sure you've reviewed our contribution guidelines at
> https://publiclab.org/contributing-to-public-lab-software > > Thanks! >
------------------------------ > You can view, comment on, or merge this
pull request online at: > > #824
<#824> > Commit Summary > > -
Bumping rails version > > File Changes > > - *M* Gemfile >
https://github.com/publiclab/mapknitter/pull/824/files#diff-0 (4) > - *M*
Gemfile.lock >
https://github.com/publiclab/mapknitter/pull/824/files#diff-1 (131) > >
Patch Links: > > - https://github.com/publiclab/mapknitter/pull/824.patch
> - https://github.com/publiclab/mapknitter/pull/824.diff > > — > You are
receiving this because you are subscribed to this thread. > Reply to this
email directly, view it on GitHub > <#824
<#824>?email_source=notifications&email_token=AAAF6J6XGCTGN7NXDOO4KJTP6SZWVA5CNFSM4H7HD3Y2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G6ESRFQ>,
> or mute the thread >
https://github.com/notifications/unsubscribe-auth/AAAF6J7RBR5CLPG4LNUPQFLP6SZWVANCNFSM4H7HD3YQ
> . >
Yes, I could open a MR upgrading to latest ruby. BTW can I push Rails 5 to
unstable?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#824?email_source=notifications&email_token=AAAF6J3DE2OH6RSNXDETANDP6T5PJA5CNFSM4H7HD3Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZRRXPA#issuecomment-509811644>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAF6J3MHHPWUQEE6UXKHETP6T5PJANCNFSM4H7HD3YQ>
.
|
Codecov Report
@@ Coverage Diff @@
## development #824 +/- ##
===============================================
- Coverage 74.03% 73.20% -0.83%
===============================================
Files 40 40
Lines 1398 1396 -2
===============================================
- Hits 1035 1022 -13
- Misses 363 374 +11
|
8e9fd3f to
2abced6
Compare
app/assets/javascripts/uploads.js
Outdated
| @@ -5,7 +5,7 @@ | |||
| //= require blueimp-file-upload/js/jquery.fileupload-ui | |||
|
|
|||
| // iframe-transport is ajax file upload support for IE, Uncomment if needed | |||
| // javascript_include_tag (file_upload + "js/jquery.iframe-transport") | |||
| // javascript_pack_tag (file_upload + "js/jquery.iframe-transport") | |||
There was a problem hiding this comment.
This is not working.
I get ActionView::Template::Error: undefined method javascript_pack_tag'`
There was a problem hiding this comment.
I know, the webpacker integration is not working.
There was a problem hiding this comment.
There's a problem with the installation itself. The rake task doesn't work after adding webpacker to the gemfile.
Last deployment broke the exporter in production, this change of settings fixed it.
Bumps [puma](https://github.com/puma/puma) from 4.3.1 to 4.3.3. **This update includes security fixes.** - [Release notes](https://github.com/puma/puma/releases) - [Changelog](https://github.com/puma/puma/blob/master/History.md) - [Commits](puma/puma@v4.3.1...v4.3.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* Styled login page to align and pad contents * added id to 'new.html.erb div' Co-authored-by: gr455 <ruturaj.mohite.iiitb.org>
Bumps [will_paginate](https://github.com/mislav/will_paginate) from 3.1.8 to 3.3.0. - [Release notes](https://github.com/mislav/will_paginate/releases) - [Commits](mislav/will_paginate@v3.1.8...v3.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
* adjust pagination param for gallery and search pages fixes #1267 * Update _maps.html.erb
* fix front page map for new LEL version * Update routes.rb * Update routes.rb * Update routes.rb
* Fixing origin validation Re #1264 * Update not_at_origin_validator.rb
* Shortening docker image in ~30% * Caching bundle, gathering env variables and using newer sintax * Creating startup script and env file * Improving travis CI configuration * Loading assets in production env * Allow uglifier to interpret ES6 * Fix start command * Fix travis script * Tweak travis script * Add delay * Revert assets changes * Return to Mysql5.7 * Tweak travis script * Fix make redeploy-container command * Add db migrate and precompile step. * Add bower install to Makefile * Clean after docker run. Avoid one bower run. * Changes to be able to build container in Google Cloud * Remove spurious symlink * Copy config examples when making build * Export env variable name * Tag cloud image * Add timeout * Push to cloud registry * Fix jenkins build error with docker-compose tty * Add app to container and .dockerignore all else * Copy configuration files when deploying to GCE * Allow copy config to container * Time extended (for cloud build & push) * Delete redundant index.html.erb file (#427) * Setupcoveralls (#438) * Add coveralls * Fix gemfile * Fix env variable * Add coveralls token * Update README.md * Remove legacy image controller code #404 (#417) Deleted the lines from the selection indicated in the issue. * Change comment count on comment creation via AJAX #441 (#443) This closes issue #441 "Change comment count on comment creation via AJAX #441" by incrementing comments-number each time a new comment is added. This would ensure that the counter indicating the number of comments is increased without needing to refresh the page. * update syntax of active record query(license method) (#439) Fixes #437 * Docker improve rebased (#450) * Shortening docker image in ~30% * Caching bundle, gathering env variables and using newer sintax * Creating startup script and env file * Improving travis CI configuration * Loading assets in production env * Allow uglifier to interpret ES6 * Don't dettach when building container in travis * Fix start command * Fix travis script * Try to resolve travis tests invocation * Tweak travis script * Add delay * Bundle install before db setup * Shortening docker image in ~30% * Caching bundle, gathering env variables and using newer sintax * Creating startup script and env file * Improving travis CI configuration * Loading assets in production env * Allow uglifier to interpret ES6 * Fix start command * Fix travis script * Tweak travis script * Add delay * Revert assets changes * Return to Mysql5.7 * Tweak travis script * Fix make redeploy-container command * Add db migrate and precompile step. * Add bower install to Makefile * Clean after docker run. Avoid one bower run. * updte pr template (#448) * Bump recaptcha from 4.13.1 to 4.13.2 (#452) Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.13.1 to 4.13.2. - [Release notes](https://github.com/ambethia/recaptcha/releases) - [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md) - [Commits](ambethia/recaptcha@v4.13.1...v4.13.2) Signed-off-by: dependabot[bot] <support@dependabot.com> * Restructure rake test task runner (#380) * add a mysql setup file * Squash commits * Update README.md (#456) * Change run to exec (#457) * Bump paperclip from 4.2.4 to 4.3.7 (#285) Bumps [paperclip](https://github.com/thoughtbot/paperclip) from 4.2.4 to 4.3.7. - [Release notes](https://github.com/thoughtbot/paperclip/releases) - [Changelog](https://github.com/thoughtbot/paperclip/blob/v4.3.7/NEWS) - [Commits](thoughtbot/paperclip@v4.2.4...v4.3.7) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump test-unit from 3.3.0 to 3.3.1 (#458) Bumps [test-unit](https://github.com/test-unit/test-unit) from 3.3.0 to 3.3.1. - [Release notes](https://github.com/test-unit/test-unit/releases) - [Commits](test-unit/test-unit@3.3.0...3.3.1) Signed-off-by: dependabot[bot] <support@dependabot.com> * Bump coveralls from 0.7.1 to 0.8.22 (#453) Bumps [coveralls](https://coveralls.io) from 0.7.1 to 0.8.22. Signed-off-by: dependabot[bot] <support@dependabot.com> * gridview aligned (#464) * Alert improvement and adding byebug gem (#383) * byebug gem added and alerts in separate file * adding byebug history to gitignore * adding timestamp to redirect * added z-index to render login dropdown above leaflet icon * fixed image partial rendering when no images (#423) * fixed image partial rendering when no images. * toggle no images <p> om upload * fixed image partial rendering when no images. * Bump recaptcha from 4.13.2 to 4.14.0 (#471) Bumps [recaptcha](https://github.com/ambethia/recaptcha) from 4.13.2 to 4.14.0. - [Release notes](https://github.com/ambethia/recaptcha/releases) - [Changelog](https://github.com/ambethia/recaptcha/blob/master/CHANGELOG.md) - [Commits](ambethia/recaptcha@v4.13.2...v4.14.0) Signed-off-by: dependabot[bot] <support@dependabot.com> * add a flash error when adding tags and not logged in (#473) * Upgrade app to Bootstrap 4 (#480) * Bootstrap 4 small button fixes (#488) * Add tests for comments and maps (#467) * Updated query style (#436) (#469) * Dynamic ports (#462) * Dynamic port in compose file * Omit setting container name * Add initial sql dump entry * Avoid resetting database on build * Shortening docker image in ~30% * Caching bundle, gathering env variables and using newer sintax * Creating startup script and env file * Improving travis CI configuration * Loading assets in production env * Tweak travis script * Roll back to using Debian 9 with custom built GDAL (#489) * Switch back to Debian 9 Stretch * Simplify docker image * Bump Ruby to 2.4.6 * Re-add dependency * Add dependency (zip) * Try pip install gdal * Install libgdal-dev * Revert attept to use pip * Bump ruby * Avoid naming containers in compose file * Avoid overwriting database on redeploy-container * Allow to load mysql dump * Include own GDAL packages * Disable ipv6 to prevent error * Add missing Amazon S3 yml to Makefile * Document unstable instance * Changes to be able to build container in Google Cloud * Copy config examples when making build * Add app to container and .dockerignore all else * Fixed missed merge * Add db configurability by env vars for containers * Fix db config * Copy configs * Switch keyserver * Add env vars, tweak make * Substitute env vars parameters * Env var control * Show env vars * env not ENV * add DB_SOCKET * Add recomended parameters * Not deploy app engine, show cloudsql dir * Omit list cloudsql dir * Added correct image tag * Add database parameters as env vars * Support $PORT env var * Using Node 12 and Yarn for Dockerfile.txt as well * Changing Passenger's port on production env * Setting local db for travis * set .env PORT to $PORT * Remove .env * Compose environment variableZ fallback * Revert all files under /app to versions in main * Revert to main * Delete unneeded files * Remove extra files from rebase * Add bundle install as build step * Deleted not needed Dockerfile * Missed RUN in Dockerfile * Add precompile step * Hardcode environment at build time * Adding missing yaml and update bootsnap version * Omit /app/tmp from volume * Revert try to get precompile to work * Clean up patch for merging * List variables in app.yaml * Tweak for jenkins * Add .env for jenkins * Fix PORT for jenkins/docker-compose * Address PORT properly * New form ports * Enclose docker-compose ports in quotes * ports yaml should be object not array * Try different format for ports * Try docker-compose format * Redirect script for AppEngine * Try to revertt to working condition for appengine * Point PORT in Procfile * Revert to known good config in appengine * Tweak assets precompilation * Restore PORT setting * Add redirect to map /warps directory to legacy archive * Add .env for jenkins/docker-compose * Add hardcoded route to legacy warps * Remove .env for appengine * Satisfy appengine docker-compose * Ignore app.yaml * Ignore app.yaml secrets * Satisfy Jenkins wihout hurting appengine hopefully Co-authored-by: Sebastian Silva <sebastian@fuentelibre.org> Co-authored-by: rarrunategu1 <parker.rose@ymail.com> Co-authored-by: Jeffrey Warren <jeff@unterbahn.com> Co-authored-by: Milo MacPhail <40954168+milomacphail@users.noreply.github.com> Co-authored-by: Sonali Agrawal <sonali9696@gmail.com> Co-authored-by: Ananya Agrawal <33188930+ananya@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Sasha Boginsky <41092741+sashadev-sky@users.noreply.github.com> Co-authored-by: Kaustubh Nair <kaustubh.nair@iiitb.org> Co-authored-by: Divya Baid <32747809+divyabaid16@users.noreply.github.com> Co-authored-by: Gaurav Sachdeva <sachdeva.gaurav1997@gmail.com> Co-authored-by: Govind Jeevan <govindjeevan7@gmail.com> Co-authored-by: Cess <cessmbuguar@gmail.com> Co-authored-by: Stefanni <stefannibrasil@gmail.com> Co-authored-by: hc-barker <hc-barker@users.noreply.github.com>
01dfb08 to
9660f8a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #603 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/mapknitter-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!