Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach Sentry to recognize docker-compose project as environment #1252

Merged
merged 1 commit into from
Apr 13, 2020

Conversation

icarito
Copy link
Member

@icarito icarito commented Apr 8, 2020

This is analogous to publiclab/plots2#7796

It's meant to avoid events from staging to alert admins.

Fixes https://github.com/steviepubliclab/web/issues/268

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • PR is descriptively titled 📑 and links the original issue above 🔗
  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • code is in uniquely-named feature branch and has no merge conflicts 📁
  • screenshots/GIFs are attached 📎 in case of UI updation
  • ask @publiclab/mapknitter-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@codeclimate
Copy link

codeclimate bot commented Apr 8, 2020

Code Climate has analyzed commit ad09542 and detected 0 issues on this pull request.

View more on Code Climate.

@icarito
Copy link
Member Author

icarito commented Apr 8, 2020

Testing this in unstable

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1252 into main will increase coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1252      +/-   ##
==========================================
+ Coverage   72.92%   73.28%   +0.35%     
==========================================
  Files          40       40              
  Lines        1400     1400              
==========================================
+ Hits         1021     1026       +5     
+ Misses        379      374       -5     
Impacted Files Coverage Δ
lib/exporter.rb 94.17% <0.00%> (+2.24%) ⬆️

Copy link
Collaborator

@cesswairimu cesswairimu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cesswairimu cesswairimu merged commit 1fc86ad into publiclab:main Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants