Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise Gruntfile #887

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Revise Gruntfile #887

merged 1 commit into from
Mar 18, 2019

Conversation

harshkhandeparkar
Copy link
Member

@harshkhandeparkar harshkhandeparkar commented Mar 18, 2019

Fixes #875

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • code is in uniquely-named feature branch and has no merge conflicts
  • PR is descriptively titled
  • ask @publiclab/is-reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

@harshkhandeparkar
Copy link
Member Author

@jywarren @publiclab/is-reviewers

@harshkhandeparkar
Copy link
Member Author

@jywarren I have revised the gruntfile. This can be merged even now. Please have a look

@jywarren
Copy link
Member

Really nicely done, thank you @harshkhandeparkar !!! 👍 🎉

@jywarren jywarren merged commit b8beec9 into main Mar 18, 2019
@harshkhandeparkar harshkhandeparkar deleted the gruntfile-revise branch March 19, 2019 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants