You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@publiclab/is-reviewers this was suggested already but we didn't follow-up, so I'm opening a new issue for it. It seems this exists now, but it's not well documented.
Copying in the last note from that issue via @harshkhandeparkar on this distinct issue:
Yes. Definitely. I think the gruntfile should be revised. Its very messy as of now. The ui dist files are not built in the build task. All the targets of a task are mentioned whereas the whole taskname can be used. Like instead of adding browserify:dist browserify:js uglify:dist uglify:js to the build task, browserify ulgify is enough. Etc. Can somebody open a new issue for that or do taht directly?
So, I think we currently have:
grunt build - just do everything below
grunt browserify - just generate dist/image-sequencer.js
@publiclab/is-reviewers this was suggested already but we didn't follow-up, so I'm opening a new issue for it. It seems this exists now, but it's not well documented.
Copying in the last note from that issue via @harshkhandeparkar on this distinct issue:
So, I think we currently have:
grunt build
- just do everything belowgrunt browserify
- just generatedist/image-sequencer.js
grunt uglify - minify
dist/image-sequencer.jsto
dist/image-sequencer.min.js`Is this correct? I believe we could also better show building UI files, so instead of current
grunt browserify:js
it should begrunt browserify:ui
?https://github.com/publiclab/image-sequencer/blob/main/Gruntfile.js#L56
Let's especially make it clear to people that:
grunt build
but onlygrunt browserify
?Is this correct?
The text was updated successfully, but these errors were encountered: