[Fixed] Add Qr Module not working #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1572 +/- ##
==========================================
+ Coverage 66.61% 66.64% +0.02%
==========================================
Files 130 130
Lines 2672 2674 +2
Branches 430 430
==========================================
+ Hits 1780 1782 +2
Misses 892 892
|
|
Node v-8 test for add QR if failing consistently... |
|
Hi @root00198 this is already fixed in #1564 |
|
Okay, Can you also fix the add-qr test module... |
|
Yea sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Qr Module was not working..
#1532 Broke the addQr Module. The funtion that it removed was not redundant.
By mistake, I created some changes in my travis-fix PR. Which were not ment to be pushed...But I pushed them accidentally, hence breaking the test. This PR will fix all those issues. That's why #1532's travis test passed....
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm run test-all@publiclab/is-reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!