-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove redundant AddQR function #1532
remove redundant AddQR function #1532
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1532 +/- ##
=======================================
Coverage 66.61% 66.61%
=======================================
Files 130 130
Lines 2672 2672
Branches 430 430
=======================================
Hits 1780 1780
Misses 892 892 |
does this look okay? |
Have you checked other modules too instead of AddQr? |
Not sure i understand what you mean? |
Trying to merge the pull request, but i'm not authorized. How do i proceed? |
@jywarren will merge your PR. |
Congrats on merging your first pull request! 🙌🎉⚡️ |
Great! Finally merged!!! |
Thank you!! 🎉 |
@jywarren This PR has broke Add-QR Module. Don't know why this happened. |
Fixes #1498 Redundant changePixel Function
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
npm test
@publiclab/is-reviewers
for help, in a comment belowIf tests do fail, click on the red
X
to learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part
Thanks!