Use Location problem solved

[NitinBhasneria]

Fixes : #305

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
• code is in uniquely-named feature branch and has no merge conflicts
• PR is descriptively titled
• PR body includes fixes #0000-style reference to original issue #
• ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

[welcome]

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

[NitinBhasneria]

@VladimirMikulic @sagarpreet-chadha there is a error in grunt jasmine showing
Fatal error: Callback must be a function please guide

[VladimirMikulic]

@NitinBhasneria I suspect that your tests are failing because you changed the function calls from editor.mapModule.blurredLocation.geocodeWithBrowser(true); to myFunctionLocation().

[NitinBhasneria]

@VladimirMikulic Do you have any solution for this as it is necessary to change the call function.

[VladimirMikulic]

Unfortunately, I don't. Your best bet is to look at the callstack & tests and try to pinpoint the problem.

[NitinBhasneria]

Ok thanks

[NitinBhasneria]

@cesswairimu @nstjean @jywarren ppease review

[cesswairimu]

@NitinBhasneria could you please checkoutbthe Travis failures? Thanks

[NitinBhasneria]

@cesswairimu In grunt jasmine, the error is Fatal error: Callback must be a function
and on Travis this is :

Also, I don't think this is the error due to pr as my other PR's are having the same error. What do you think?

[cesswairimu]

@NitinBhasneria I see this is happening to all of the recent PRs opened an issue for this here #439

[NitinBhasneria]

@VladimirMikulic Can you check this PR and approve.

[VladimirMikulic]

Please write more descriptive names. How am I supposed to know what is n, e, str1, str?

[VladimirMikulic]

Other namings are great. That's how it should always be 👍

[VladimirMikulic]

Now it's clear 🎖️

[NitinBhasneria]

@jywarren This is ready.

[cesswairimu]

@NitinBhasneria @govindgoel @VladimirMikulic apparently as it is now...we are not experiencing this issue...must have been solved on another issue and the issue was never closed....kindly confirm this

[NitinBhasneria]

Thank you @cesswairimu I checked it again but in branch master, the issue is still there.

[jywarren]

I think this looks good to merge; but maybe what @cesswairimu is saying is that this may not be occurring on PublicLab.org -- this fix is for the demo just in the editor repository. Could that be the ambiguity?

[welcome]

Congrats on merging your first pull request! 🙌🎉⚡️
Your code will likely be published to PublicLab.org in the next few days. In the meantime, can you tell us your Twitter handle so we can thank you properly?
Do join our weekly check-in to share your this week goal and the awesome work you did 😃.
Reach out to someone else working on theirs on Public Lab's code welcome page. Thanks!
Now that you've completed this, you can help someone else take their first step!
See: Public Lab's coding community!

Help others take their first step

Now that you've merged your first pull request, you're the perfect person to help someone else out with this challenging first step. 🙌

https://code.publiclab.org

Try looking at this list of `first-timers-only` issues, and see if someone else is waiting for feedback, or even stuck! 😕

People often get stuck at the same steps, so you might be able to help someone get unstuck, or help lead them to some documentation that'd help. Reach out and be encouraging and friendly! 😄 🎉

Read about how to help support another newcomer here, or find other ways to offer mutual support here.

[jywarren]

Thanks all, but let's file/open a follow-up if there are ambiguities remaining! Thanks!!! 🎉