Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple font awesome loading icon in maps module . #305

Closed
sagarpreet-chadha opened this issue Mar 16, 2019 · 2 comments · Fixed by #436
Closed

Multiple font awesome loading icon in maps module . #305

sagarpreet-chadha opened this issue Mar 16, 2019 · 2 comments · Fixed by #436

Comments

@sagarpreet-chadha
Copy link
Contributor

Please describe the problem (or idea)

In map module , when we use the Use Current Location button and if user denies permission to give her location , the spinner still persists .

Moreover if we click again the button and again user denies access to location , there comes 2 spinners .
Screenshot 2019-03-16 at 2 02 12 PM

Solution

Let's remove the spinner if :
1.) User denies to give access to her location .
2.) If by default the browser settings do not allow access to location .


Thank you!

@DevanshCodes
Copy link
Member

Hey! can I work on this?

@shreyaa-s-zz
Copy link
Collaborator

Hey @sagarpreet-chadha , I'm an outreachy applicant and i would like to work on this issue if it is up for grabs. Can you please assign it to me? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants