Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Help: KolRadioButton hint #6455

Closed
agnieszkaw61 opened this issue May 23, 2024 · 1 comment · Fixed by #6695
Closed

📖 Help: KolRadioButton hint #6455

agnieszkaw61 opened this issue May 23, 2024 · 1 comment · Fixed by #6695
Assignees
Labels
help wanted Extra attention is needed

Comments

@agnieszkaw61
Copy link

Note

  • Ich achte beim Erstellen des Issues darauf, dass ich keine fachlichen und unternehmensinternen Details preisgebe.

Hilfeanfrage

Beschreiben Sie möglichst genau, wobei wir Ihnen helfen können.

RadioButton-Komponent bietet einen "_hint" Property, aber es erlaubt nur ein string und deshalb es ist dasselbe fur jede Option:

image

ist es moglich dass jede Optione andere hint hat?

@agnieszkaw61 agnieszkaw61 added the help wanted Extra attention is needed label May 23, 2024
@deleonio
Copy link
Contributor

deleonio commented Jul 31, 2024

Soll:

  • Der Hint soll nicht an die Radio-Inputs weitergegeben werden, sondern nur einmal unterhalb der Fehlermeldung sein.
  • Einführen der RadioOptions mit neuem optionalen description diese soll dann als _hint an die kol-input-wc weitergeben werden.
  • Beispiel in der Sample-App dazu machen
  • Snapshots aktualisieren

Image

type Option<T> = {
  label: "Deutschland",
  value:? T,
}

type RadioOption<T> = Option<T> & {
  description:?  string
}

@deleonio deleonio moved this from Backlog to 📄 Ready in KoliBri Board Jul 31, 2024
@anicyne anicyne self-assigned this Jul 31, 2024
@anicyne anicyne moved this from 📄 Ready to 🏗 In progress in KoliBri Board Aug 1, 2024
anicyne added a commit that referenced this issue Aug 2, 2024
@anicyne anicyne linked a pull request Aug 2, 2024 that will close this issue
publicuibot bot pushed a commit that referenced this issue Aug 2, 2024
anicyne added a commit that referenced this issue Aug 2, 2024
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Aug 2, 2024
@anicyne anicyne moved this from 🔍 Review to 🏗 In progress in KoliBri Board Aug 5, 2024
publicuibot bot pushed a commit that referenced this issue Aug 5, 2024
@anicyne anicyne moved this from 🏗 In progress to 🔍 Review in KoliBri Board Aug 5, 2024
anicyne added a commit that referenced this issue Aug 7, 2024
anicyne added a commit that referenced this issue Aug 7, 2024
sdvg added a commit that referenced this issue Aug 8, 2024
publicuibot bot pushed a commit that referenced this issue Aug 8, 2024
anicyne added a commit that referenced this issue Aug 8, 2024
anicyne added a commit that referenced this issue Aug 8, 2024
anicyne added a commit that referenced this issue Aug 9, 2024
anicyne added a commit that referenced this issue Aug 9, 2024
anicyne added a commit that referenced this issue Aug 9, 2024
@sdvg sdvg self-assigned this Aug 26, 2024
publicuibot bot pushed a commit that referenced this issue Aug 26, 2024
@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Aug 26, 2024
sdvg added a commit that referenced this issue Aug 27, 2024
…dropdown-clipping-shadow-dom

* 'develop' of github.com:public-ui/kolibri:
  Update all snapshots$ $ Refs: #6455
  fix: adjusted code based on review
  fix: adjusted code based on review
  Update all snapshots$ $ Refs: #6455
  Add more option descriptions to sample
  fix format error
  fix format errors
  Update all snapshots$ $ Refs: #6455
  Translate input-radio labels and options to English.
  Fix input-radio test
  Update all snapshots$ $ Refs: #6455
  Update input-radio with hint and description
sdvg added a commit that referenced this issue Aug 27, 2024
…e-selection-radio

* 'develop' of github.com:public-ui/kolibri: (31 commits)
  Update all snapshots$ $ Refs: #6455
  Remove ID attribute from associated form fields
  Revert change
  Update Readme files
  Update all snapshots$ $ Refs: #6341
  chore: remove branch param
  fix: format
  Set default spinner color to black
  remove duplicate ids
  aside scrollable
  fix format
  changed color danger button
  Correct capitalization
  translate property names
  Example with font icons in the table
  Update all snapshots$ $ Refs: #6705
  Adjusted code based on review
  fix: adjusted code based on review
  Update all snapshots$ $ Refs: #6705
  fix: adjusted code based on review
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants