fix: adjusted code based on review

Refs: #6455
public-ui · Aug 9, 2024 · ce423bf · ce423bf
1 parent 7278336
commit ce423bf
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/packages/components/src/components/input-radio/shadow.tsx b/packages/components/src/components/input-radio/shadow.tsx
@@ -168,7 +168,7 @@ export class KolInputRadio implements InputRadioAPI, FocusableElement {
 						);
 					})}
 					{hasError && <FormFieldMsg _alert={this.state._alert} _hideError={this.state._hideError} _msg={this.state._msg} _id={this.state._id} />}
-					{hasHint && <span class="hint">{this._hint}</span>}
+					{hasHint && <span class="hint">{this.state._hint}</span>}
 				</fieldset>
 			</Host>
 		);

diff --git a/packages/components/src/components/input-radio/test/html.mock.ts b/packages/components/src/components/input-radio/test/html.mock.ts
@@ -119,7 +119,7 @@ export const getInputRadioHtml = (props: InputRadioProps): string => {
 					hasHint
 						? `
 						<span class="hint" id="${state._id}-hint">
-							{this._hint}
+							${state._hint}
 						</span>`
 						: ''
 				}

diff --git a/packages/components/src/components/input-radio/test/snapshot.spec.tsx b/packages/components/src/components/input-radio/test/snapshot.spec.tsx
@@ -27,7 +27,7 @@ executeTests<InputRadioProps>(
 		_options: [
 			[
 				{ label: 'Field 1', value: 1 },
-				{ label: 'Field 2', value: 2, description: 'description' },
+				{ label: 'Field 2', value: 2, hint: 'description' },
 			],
 			[{ label: 'Field 1', value: { id: 1, name: 'Option 1' } }],
 		],

diff --git a/packages/themes/ecl/src/components/ecl-ec/input-radio.scss b/packages/themes/ecl/src/components/ecl-ec/input-radio.scss
@@ -9,13 +9,13 @@
 
 	fieldset {
 		border: 0;
-		gap: 0.5rem;
+		gap: rem(8);
 		flex-wrap: wrap;
 		align-items: flex-start;
 	}
 
 	.input-slot {
-		gap: 0.25rem;
+		gap: rem(4);
 	}
 
 	fieldset .kol-alert-wc {
@@ -24,7 +24,7 @@
 
 	fieldset .hint {
 		order: 4;
-		font-size: 0.875rem;
+		font-size: rem(14.4);
 		font-style: italic;
 	}
 
@@ -39,7 +39,7 @@
 
 	fieldset .kol-input .hint {
 		order: 3;
-		font-size: 0.875rem;
+		font-size: rem(14.4);
 		font-style: italic;
 	}
 
@@ -54,7 +54,7 @@
 	}
 
 	.radio-label {
-		padding-left: 0.5rem;
+		padding-left: rem(8);
 	}
 
 	input[type='radio'] {

diff --git a/packages/themes/ecl/src/components/ecl-eu/input-radio.scss b/packages/themes/ecl/src/components/ecl-eu/input-radio.scss
@@ -9,7 +9,7 @@
 
 	fieldset {
 		border: 0;
-		gap: 0.5rem;
+		gap: rem(8);
 		flex-wrap: wrap;
 		align-items: flex-start;
 	}
@@ -20,7 +20,7 @@
 
 	fieldset .hint {
 		order: 4;
-		font-size: 0.875rem;
+		font-size: rem(14.4);
 		font-style: italic;
 	}
 
@@ -35,7 +35,7 @@
 
 	fieldset .kol-input .hint {
 		order: 3;
-		font-size: 0.875rem;
+		font-size: rem(14.4);
 		font-style: italic;
 	}
 
@@ -50,7 +50,7 @@
 	}
 
 	.radio-label {
-		padding-left: 0.5rem;
+		padding-left: rem(8);
 	}
 
 	input[type='radio'] {