SG-645 Update cw-nfts version #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to humanalgorihtm/update-cw-nfts-version
Cosm-Orc Gas Usage
Raw Report for 7f9f9a5
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
- Coverage 57.59% 57.04% -0.56%
==========================================
Files 72 72
Lines 3415 3476 +61
==========================================
+ Hits 1967 1983 +16
- Misses 1448 1493 +45
☔ View full report in Codecov by Sentry. |
shanev
requested changes
Apr 7, 2023
…to humanalgorihtm/update-cw-nfts-version
yubrew
reviewed
Apr 20, 2023
| NftInfo { | ||
| token_id: String, | ||
| }, | ||
| #[returns(NftInfoResponse<Empty>)] |
There was a problem hiding this comment.
double check this works for sg721-metadata-onchain
There was a problem hiding this comment.
How to double check? Do you mean after merge?
yubrew
reviewed
Apr 20, 2023
|
Update 4-24-2023: This is now using the inherited migrations from cw_721 base per larry0x PR: public-awesome/cw-nfts#119 |
…or sg721-updateable with ownable migration
shanev
reviewed
May 9, 2023
jhernandezb
requested changes
May 18, 2023
shanev
approved these changes
May 19, 2023
SG-645 Upgrade NFT contracts to cw-nfts v0.17
This gives us some new features like transferring ownership that creators have been asking for. |
|
Updated title so linear catches issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update 4-24-2023: This is now using the inherited migrations from cw_721 base per larry engineer PR: public-awesome/cw-nfts#119
Updating to the latest cw-nfts 0.17 and the necessary changes.
Notes:
In order to update to cw 0.17 need to update the Rust version to 1.67.1. You will see this reflected in the changes to the config.yml build script.
The MintMsg has been removed and folded into ExecuteMsg for cw721-base. Therefore we now need to put the variant for Mint { } in each relevant msg module.
Need to use a NftParams enum for nft data passed to mint function. This is such as to not have too many parameters passed to the function. Would use a regular struct but need to be able to plug into the T extension parameter.