Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
cw721_base::upgrades
is not exported, but it should be. It is needed by custom NFT contracts that extends cw721-base to implement their custom migration logics.Let's consider a contract called sg721-base that extends cw721-base. Also assume:
How should sg721-base implement its 0.25 => 0.26 migration? Imo, the cleanest way is this:
This is somewhat similar to how inheritance works in Python:
See how the child contract needs to invoke
cw721_base::upgrades::v0_17::migrate
similar to how the python class invokes its parent's method by__super__
.Similarly, if a contract extends sg721-base, then it should also invoke
sg721_base::upgrades::v0_26::migrate
in its custom migration method.