Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OpsGenie Tags field #1108

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Fix OpsGenie Tags field #1108

merged 1 commit into from
Nov 15, 2017

Conversation

Tom-Fawcett
Copy link
Contributor

#1061 broke the OpsGenie Tags field.

The structure of this field has in fact changed between v1 and v2.

OpsGenie Documentation

I have used strings.Split to preserve functionality without changing config.

Tests

  • No tag config set. ✓
  • One tag value set. ✓
  • Multiple tags set. ✓

I apologise for missing this in #1061.

@Tom-Fawcett Tom-Fawcett mentioned this pull request Nov 15, 2017
Closed
@stuartnelson3 stuartnelson3 mentioned this pull request Nov 15, 2017
Merged
@Tom-Fawcett
Copy link
Contributor Author

@stuartnelson3 would you like me to resolve the conflict and push again?

@stuartnelson3
Copy link
Contributor

that would be great

@Tom-Fawcett
Copy link
Contributor Author

Done

@stuartnelson3 stuartnelson3 merged commit 8bfbb0a into prometheus:master Nov 15, 2017
@iksaif iksaif mentioned this pull request Feb 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stuartnelson3 stuartnelson3 stuartnelson3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tom-Fawcett @stuartnelson3