OpsGenie returns 422 when team is not specified

[iksaif]

I'm still unsure if this is due to something on our side, but to help others users potentially affected by this I'm creating this issue.

Using the opsgenie notifier, we started to get the following error (with both 0.11.0 and 0.13.0).

{"message":"Request body is not processable. Please check the errors.","errors":{"teams[0]":"id or name should be provided"},"took":0.009,"requestId":"xxxxxxxxxxxxxxxxxxxxxxxxxxxx"}

this happens because the query looks like:

{..."teams":[{"name":""}],...}

we made the following very quick and dirty patch to fix the issue

$ git diff
diff --git a/notify/impl.go b/notify/impl.go
index 7eddc3e..c519039 100644
--- a/notify/impl.go
+++ b/notify/impl.go
@@ -30,6 +30,7 @@ import (
        "net/url"
        "strings"
        "time"
+       "io/ioutil"
 
        "github.com/go-kit/kit/log"
        "github.com/go-kit/kit/log/level"
@@ -837,8 +838,13 @@ func (n *OpsGenie) Notify(ctx context.Context, as ...*types.Alert) (bool, error)
                apiURL = n.conf.APIURL + "v2/alerts"
                var teams []map[string]string
                for _, t := range strings.Split(string(tmpl(n.conf.Teams)), ",") {
-                       teams = append(teams, map[string]string{"name": t})
+                       if len(t) != 0 {
+                               teams = append(teams, map[string]string{"name": t})
+                       }
                }
+               if len(teams) == 0 {
+                        teams = nil
+                }
                msg = &opsGenieCreateMessage{
                        Alias:       alias,
                        Message:     message,
@@ -859,6 +865,7 @@ func (n *OpsGenie) Notify(ctx context.Context, as ...*types.Alert) (bool, error)
        if err := json.NewEncoder(&buf).Encode(msg); err != nil {
                return false, err
        }
+       fmt.Printf("JSON: %v\n", buf.String())
 
        req, err := http.NewRequest("POST", apiURL, &buf)
        if err != nil {
@@ -868,7 +875,12 @@ func (n *OpsGenie) Notify(ctx context.Context, as ...*types.Alert) (bool, error)
        req.Header.Set("Authorization", fmt.Sprintf("GenieKey %s", n.conf.APIKey))
 
        resp, err := ctxhttp.Do(ctx, http.DefaultClient, req)
-
+       fmt.Printf("RESP: %v\n", resp)
+       if true {
+               body, _ := ioutil.ReadAll(resp.Body)
+               bodyString := string(body)
+               fmt.Printf("BODY: %v\n", bodyString)
+       }
        if err != nil {
                return true, err
        }

• Team should be kept empty if no team are specified (probably true for some other fields)
• A more detailed error than "opsgenie replied 422" should be printed when debug logs are on (probably true for all notifiers)

[iksaif]

Seems to be similar to #1108 and #1107