This repository has been archived by the owner on Oct 23, 2022. It is now read-only.
added fragment #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mzack9999
suggested changes
Jun 1, 2022
There was a problem hiding this comment.
- Remove code related to Adding support for unescaped request uri #2
- Review Adding support for unescaped request uri #2, merge it into
dev, then mergedevinto this branch - Please add a little test case related to Fragment parsing in
urlutil_test.go
Notes: depends on #2
|
Kudos, SonarCloud Quality Gate passed!
|
Mzack9999
approved these changes
Jun 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fragment support to stop url fragments being stripped.