Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates from urlutil library #646

Merged
merged 3 commits into from
Jun 4, 2022
Merged

updates from urlutil library #646

merged 3 commits into from
Jun 4, 2022

Conversation

LuitelSamikshya
Copy link
Contributor

@LuitelSamikshya LuitelSamikshya commented May 31, 2022 •
edited
Loading

This PR is dependent on the changes in projectdiscovery/urlutil#6
Test: echo https://example.com/#myfragment/path1/path2/test.html | httpx

@LuitelSamikshya LuitelSamikshya linked an issue May 31, 2022 that may be closed by this pull request
URL fragments are being stripped #627
Closed
@LuitelSamikshya LuitelSamikshya self-assigned this May 31, 2022
@LuitelSamikshya LuitelSamikshya added Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors. Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels May 31, 2022
@LuitelSamikshya LuitelSamikshya requested a review from Mzack9999 May 31, 2022 21:49
Mzack9999
Mzack9999 requested changes Jun 1, 2022
View reviewed changes
Copy link
Member

@Mzack9999 Mzack9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends on projectdiscovery/urlutil#6 (review)

@LuitelSamikshya LuitelSamikshya marked this pull request as draft June 2, 2022 04:38
@LuitelSamikshya LuitelSamikshya marked this pull request as ready for review June 2, 2022 05:02
@LuitelSamikshya LuitelSamikshya requested a review from Mzack9999 June 2, 2022 05:03
@ehsandeep ehsandeep merged commit 3743d2f into dev Jun 4, 2022
@ehsandeep ehsandeep deleted the issue-627-url-fragments-being-stripped branch June 4, 2022 17:31
@ehsandeep ehsandeep added Status: Completed Nothing further to be done with this issue. Awaiting to be closed. and removed Status: Review Needed The issue has a PR attached to it which needs to be reviewed labels Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@Mzack9999 Mzack9999 Mzack9999 approved these changes

Assignees

@LuitelSamikshya LuitelSamikshya

Labels
Status: Completed Nothing further to be done with this issue. Awaiting to be closed. Type: Bug Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

URL fragments are being stripped
3 participants
@LuitelSamikshya @ehsandeep @Mzack9999