Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: drop specific-commit deps for dirs/term #597

Merged
merged 1 commit into from
Feb 12, 2020
Merged

examples: drop specific-commit deps for dirs/term #597

merged 1 commit into from
Feb 12, 2020

Conversation

daviddrysdale
Copy link
Contributor

Commit d362ebd ("Update Rust version (#588)") upgraded the
'dirs' (2.0.1->2.0.2) and 'term' (0.5.2->0.6.1) dependencies so
the pins to particular commits are no longer needed.

Commit d362ebd ("Update Rust version (#588)") upgraded the
'dirs' (2.0.1->2.0.2) and 'term' (0.5.2->0.6.1) dependencies so
the pins to particular commits are no longer needed.
@tiziano88
Copy link
Collaborator

Just checking: will rustfmt still build after removing these? I don't remember whether they were added for it, and now that that example is disabled, I wouldn't want us to accidentally remove some deps that are needed.

@daviddrysdale
Copy link
Contributor Author

The rustfmt example built for me (once I remembered to update my local Rust compiler), but I guess Cloudbuild will tell us definitively. (AIUI the rustfmt example doesn't get run at the moment (#594) but should get built by the run_tests step).

@daviddrysdale daviddrysdale merged commit d8e0de3 into project-oak:master Feb 12, 2020
@daviddrysdale daviddrysdale deleted the drop-patch branch February 12, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants