Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable rustfmt example when rustc ICE is fixed #594

Closed
blaxill opened this issue Feb 11, 2020 · 0 comments · Fixed by #1076
Closed

Reenable rustfmt example when rustc ICE is fixed #594

blaxill opened this issue Feb 11, 2020 · 0 comments · Fixed by #1076
Labels
blocked This pull request is blocked by another pull request or issue lang/Rust

Comments

@blaxill
Copy link
Contributor

blaxill commented Feb 11, 2020

Running rustfmt example in run_examples was disabled in #588, due to a rustc internal error. Once the issue is fixed upstream we can reenable rustfmt.

Blocked on rust-lang/rust#64450
@blaxill blaxill added the blocked This pull request is blocked by another pull request or issue label Feb 11, 2020
blaxill added a commit to blaxill/oak that referenced this issue Feb 11, 2020
@blaxill
Add TODO(project-oak#594)
5184c82
blaxill added a commit that referenced this issue Feb 11, 2020
@blaxill
Update Rust version (#588)
d362ebd 
Temporarily disables rustfmt example due to rust compiler error see #594
@daviddrysdale daviddrysdale mentioned this issue Feb 12, 2020
Merged
This was referenced May 27, 2020
Closed
Merged
Merged
daviddrysdale added a commit that referenced this issue Jun 3, 2020
@daviddrysdale
examples: drop rustfmt example (#1076)
ed5866b 
This example doesn't show anything that's not demonstrated by other
examples, and it needs nightly channel Rust which keeps causing
problems (and prevents us moving to the stable channel).

Fixes #1075.  Fixes #594.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked This pull request is blocked by another pull request or issue lang/Rust
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

examples: drop rustfmt example
2 participants
@tiziano88 @blaxill