Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update demos for v0.6.1 #296

Merged
merged 8 commits into from
Aug 11, 2023

Conversation

Maxusmusti
Copy link
Collaborator

@Maxusmusti Maxusmusti commented Aug 9, 2023

Issue link

#281

What changes have been made

  • Updated notebooks to reflect changes in v0.6.1
  • Also polished various bits to be more informative/up-to-date

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 9, 2023
@Maxusmusti Maxusmusti marked this pull request as ready for review August 10, 2023 00:37
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 10, 2023
src/codeflare_sdk.egg-info/SOURCES.txt Outdated Show resolved Hide resolved
demo-notebooks/batch-job/batch_mnist_mcad.ipynb Outdated Show resolved Hide resolved
demo-notebooks/guided-demos/preview_nbs/0_basic_ray.ipynb Outdated Show resolved Hide resolved
@jbusche
Copy link
Contributor

jbusche commented Aug 10, 2023

OK - tested against @anishasthana PR 910 and it looked good except for two items:

  1. I can't run everything because I don't have GPUs, but I'm seeing the following issue with the 4_gpt.ipynb guided demo:
ERROR: pip\'s dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.\n\x1b[2m\x1b[36m(CommandActor pid=230, ip=10.254.16.39)\x1b[0m [0]:tensorboardx 2.6 requires protobuf<4,>=3.8.0, but you have protobuf 4.24.0 which is incompatible.
  1. As @tedhtchang mentioned, I liked the batch demos... was it really intended to have them removed?

@Maxusmusti
Copy link
Collaborator Author

@tedhtchang @jbusche the only reason that the batch demos were removed is because they were redundant (so not actually being removed). Take a look in the PR at guided-demos/2_basic_jobs.ipynb and guided-demos/notebooks-ex-outputs/2_basic_jobs.ipynb and let me know if you feel anything in there does not encompass what was in the batch demos.

@Maxusmusti Maxusmusti requested a review from tedhtchang August 10, 2023 18:56
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
@anishasthana
Copy link
Contributor

@MichaelClifford needs to approve this PR.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2023
Copy link
Collaborator

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MichaelClifford, tedhtchang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit cecae82 into project-codeflare:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants