Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file paths and guide in Quick-Start #82

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Update file paths and guide in Quick-Start #82

merged 4 commits into from
Sep 5, 2023

Conversation

ChristianZaccaria
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria commented Aug 15, 2023 •
edited
Loading

Closes #81 and Closes #95

Description

  • Updated file paths to the guided demos based on changes made on this PR and comment.
  • Updated dead links.
  • Due to changing file paths to make use of a new demo, the quick-start tutorial needed to be adapted to reflect the changes.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • The developer has manually tested the changes and verified that the changes work

Bobbins228
Bobbins228 requested changes Aug 16, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be a good idea to update the following run the demo notebook tutorial to reflect the notebook you reference codeflare-sdk/demo-notebooks/guided-demos/2_basic_jobs.ipynb because right now the tutorial does not match what is written in that particular notebook which could cause confusion.

@ChristianZaccaria
Copy link
Contributor Author

I think it might be a good idea to update the following run the demo notebook tutorial to reflect the notebook you reference codeflare-sdk/demo-notebooks/guided-demos/2_basic_jobs.ipynb because right now the tutorial does not match what is written in that particular notebook which could cause confusion.

@Bobbins228 You're absolutely right, thank you. Hopefully the changes now make sense. I modified the tutorial to closely match what is in the notebook. Let me know what you think :)

Bobbins228
Bobbins228 requested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good fits more into what that demo notebook looks like just one minor nitpick

Quick-Start.md Show resolved Hide resolved
Quick-Start.md Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Aug 17, 2023
Bobbins228
Bobbins228 approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Aug 17, 2023
@goern goern mentioned this pull request Aug 29, 2023
Closed
@goern
Copy link
Member

goern commented Aug 30, 2023

is there any issue not merging this PR?

@ChristianZaccaria
Copy link
Contributor Author

is there any issue not merging this PR?

Currently waiting on owners approval for merge. @dimakis This should be good to go if you're okay with 👍

@ChristianZaccaria
Copy link
Contributor Author

/retest

MichaelClifford
MichaelClifford requested changes Aug 30, 2023
View reviewed changes
Quick-Start.md Outdated Show resolved Hide resolved
Quick-Start.md Show resolved Hide resolved
Quick-Start.md Show resolved Hide resolved
MichaelClifford
MichaelClifford approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@MichaelClifford MichaelClifford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, MichaelClifford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2023
@openshift-merge-robot openshift-merge-robot merged commit 3e707bc into opendatahub-io:main Sep 5, 2023
@ChristianZaccaria ChristianZaccaria changed the title Update file paths in Quick-Start Update file paths and guide in Quick-Start Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bobbins228 Bobbins228 Bobbins228 approved these changes

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@Maxusmusti Maxusmusti Awaiting requested review from Maxusmusti

@dimakis dimakis Awaiting requested review from dimakis

Assignees

@MichaelClifford MichaelClifford

@Bobbins228 Bobbins228

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Quick-Start.md links are 404 Update Quick-Start
5 participants
@ChristianZaccaria @goern @MichaelClifford @Bobbins228 @openshift-merge-robot