-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added TXT record describing CRMP intervals to operational advertising. #5841
Merged
woody-apple
merged 1 commit into
project-chip:master
from
kkasperczyk-no:sed_idle_time_txt_record_pr
Apr 8, 2021
Merged
Added TXT record describing CRMP intervals to operational advertising. #5841
woody-apple
merged 1 commit into
project-chip:master
from
kkasperczyk-no:sed_idle_time_txt_record_pr
Apr 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17a104f
to
4bdcfaa
Compare
That value should be defined in the ReliableMessageProtocolConfig.h,connectedhomeip/src/lib/mdns/Discovery_ImplPlatform.cpp Lines 267 to 277 in 4bdcfaa
This comment was generated by todo based on a
|
Issue #5833 - CRMP retry intervals should be updated on the poll period valueconnectedhomeip/src/lib/mdns/Discovery_ImplPlatform.cpp Lines 278 to 288 in 4bdcfaa
This comment was generated by todo based on a
|
andy31415
approved these changes
Apr 7, 2021
msandstedt
reviewed
Apr 7, 2021
4bdcfaa
to
2d9852c
Compare
CRMP allows setting some intervals, which assumes that data transmission does not take place in zero time and prevents from unnecessary retransmissions. In particular sleepy end devices may need more time on answering and controller should be aware of that. * Modified configs for RMP intervals defining their default values, according to spec. * Added TXT record containing default CRMP intervals information to operational advertising message. * For Thread sleepy end devices added additional time extension by its sleeping period (in fact poll period). * Fixed bug with passing local variable to otSrpSetHostName method instead of static one.
2d9852c
to
60a2557
Compare
msandstedt
approved these changes
Apr 7, 2021
Size increase report for "nrfconnect-example-build" from 1898cc4
Full report output
|
Size increase report for "esp32-example-build" from 1898cc4
Full report output
|
woody-apple
approved these changes
Apr 8, 2021
This was referenced Apr 8, 2021
jimlyall-q
pushed a commit
to jimlyall-q/connectedhomeip
that referenced
this pull request
Apr 13, 2021
project-chip#5841) CRMP allows setting some intervals, which assumes that data transmission does not take place in zero time and prevents from unnecessary retransmissions. In particular sleepy end devices may need more time on answering and controller should be aware of that. * Modified configs for RMP intervals defining their default values, according to spec. * Added TXT record containing default CRMP intervals information to operational advertising message. * For Thread sleepy end devices added additional time extension by its sleeping period (in fact poll period). * Fixed bug with passing local variable to otSrpSetHostName method instead of static one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CRMP allows setting some intervals, which assumes that data transmission does not take place in zero time and prevents
from unnecessary retransmissions. In particular sleepy end devices may need more time on answering and controller should be awareof that.
Summary of Changes
Fixes #5832