-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize thread border router management xml template file and run zap_generate_all.py #33610
Conversation
PR #33610: Size comparison from 3718e99 to e7a0a2a Increases above 0.2%:
Increases (23 builds for esp32, linux, nrfconnect, telink)
Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33610: Size comparison from 3718e99 to 1085107 Increases above 0.2%:
Increases (23 builds for esp32, linux, nrfconnect, telink)
Decreases (2 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml
Outdated
Show resolved
Hide resolved
PR #33610: Size comparison from 294dc18 to 8d047cd Increases above 0.2%:
Increases (17 builds for esp32, linux)
Decreases (4 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33610: Size comparison from 294dc18 to 4a4a413 Increases above 0.2%:
Increases (17 builds for esp32, linux)
Decreases (4 builds for efr32, linux)
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml
Outdated
Show resolved
Hide resolved
PR #33610: Size comparison from 9217d22 to 6b2e179 Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
PR #33610: Size comparison from 923854b to 472636d Increases above 0.2%:
Full report (83 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
src/app/zap-templates/zcl/data-model/chip/thread-border-router-management-cluster.xml
Outdated
Show resolved
Hide resolved
…zap_generate_all.py (project-chip#33610) * Initialize thread border router management xml template file and run zap_generate_all.py * Update the xml file * remove some struct files * breadcrumb field in SetActiveDataset command should be optional * review changes * Change BorderAgentId to BorderAgentID
|
||
<attribute side="server" code="0x0003" define="INTERFACE_ENABLED" type="boolean" default="0">InterfaceEnabled</attribute> | ||
|
||
<attribute side="server" code="0x0005" define="ACTIVE_DATASET_TIMESTAMP" type="int64u" isNullable="true">ActiveDatasetTimestamp</attribute> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix it in #33872
<command source="server" code="0x03" name="DatasetResponse" optional="false"> | ||
<description>Generated response to GetActiveDatasetRequest or GetPendingDatasetRequest commands.</description> | ||
<arg name="Dataset" type="octet_string" length="254"/> | ||
</command> | ||
|
||
<command source="client" code="0x04" name="SetActiveDatasetRequest" optional="false"> | ||
<description>Command to set or update the active Dataset of the Thread network to which the Border Router is connected.</description> | ||
<arg name="ActiveDataset" type="octet_string" length="254"/> | ||
<arg name="Breadcrumb" type="int64u" optional="true"/> | ||
<access op="invoke" privilege="manage"/> | ||
</command> | ||
|
||
<command source="client" code="0x05" name="SetPendingDatasetRequest" optional="true"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the commands to fill the "2"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Command IDs re-numbered the in spec PR#9305 to remove this gap.
"side": "client", | ||
"type": "bitmap32", | ||
"included": 1, | ||
"storageOption": "RAM", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this ZAP file seems to be missing some attributes.
<field name="PANChange" mask="0x1"/> | ||
</bitmap> | ||
|
||
<cluster> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cluseter must be marked as provisional.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tcarmelveilleux could you please detail why you think this cluster should be marked as provisional?
Step 1 of #33609
Add xml template files for thread border router management cluster and thread br device type which will be introduced in https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/8984 and generate auto-generated files.