Create a JSON Log tracing backend #27135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd linux apps at start
Ran:
```sh
rg MATTER_TRACE_EVENT_SCOPE --files-with-matches \
| grep -v src/trace \
| xargs sd \
'(^(\s*)MATTER_TRACE_EVENT_SCOPE\("(.*)",\s*"(.*)"\);)' \
"\${1}\n\${2}MATTER_TRACE_SCOPE(::chip::Tracing::Scope::\${4}_\${3});"
```
…tant is one of the cases where matter_trace did not actually work)
|
PR #27135: Size comparison from 9f93a41 to a8179ab Increases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
|
PR #27135: Size comparison from 9f93a41 to 6579f80 Increases (1 build for cc32xx)
Full report (4 builds for cc32xx, mbed, qpg)
|
|
PR #27135: Size comparison from 9f93a41 to 5ef211e Increases above 0.2%:
Increases (22 builds for bl602, bl702, cc32xx, linux, psoc6)
Decreases (1 build for esp32)
Full report (41 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
tcarmelveilleux
approved these changes
Jun 8, 2023
|
PR #27135: Size comparison from 9f93a41 to 9ae18f7 Increases above 0.2%:
Increases (10 builds for bl702, cc32xx, linux, nrfconnect, psoc6)
Decreases (2 builds for bl702)
Full report (24 builds for bl602, bl702, cc32xx, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
|
PR #27135: Size comparison from 4c78740 to d467ad3 Increases above 0.2%:
Increases (28 builds for bl602, bl702, cc32xx, esp32, linux, nrfconnect, psoc6, telink)
Decreases (4 builds for bl602, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a JSON logging backend (suitable for large systems only as it uses json) and started using it. Changes:
--trace-toargument to CHIPTool where we can incrementally redirect logs to any backend we want (as a testbed this seems the easiest) and support log for now. May rename it to log-json later in case we will have different logging.relies on #27154